Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 14682023: Add plumbing for testing API for MockWebDeviceMotionHandler injection. (Closed)

Created:
7 years, 7 months ago by timvolodine
Modified:
7 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, Miguel Garcia
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Adds methods to set a mock WebDeviceMotionProvider in the Platform layer for testing Device Motion API in Blink. BUG=135804

Patch Set 1 #

Patch Set 2 : refactored to use a mock provider approach. #

Patch Set 3 : plumbing without the WebDeviceMotionProvider #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -1 line) Patch
M content/public/test/layouttest_support.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 4 chunks +23 lines, -0 lines 0 comments Download
M content/shell/renderer/webkit_test_runner.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/renderer/webkit_test_runner.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M content/test/layouttest_support.cc View 1 2 3 chunks +7 lines, -0 lines 0 comments Download
M webkit/support/test_webkit_platform_support.h View 1 2 3 chunks +4 lines, -0 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M webkit/support/webkit_support.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/support/webkit_support.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
timvolodine
7 years, 7 months ago (2013-05-17 13:37:56 UTC) #1
jochen (gone - plz use gerrit)
For other mocks, we added a ContentRendererClient::OverrideFoo() method. Why not use the same pattern here?
7 years, 7 months ago (2013-05-21 07:35:09 UTC) #2
timvolodine
On 2013/05/21 07:35:09, jochen wrote: > For other mocks, we added a ContentRendererClient::OverrideFoo() method. Why ...
7 years, 7 months ago (2013-05-21 12:06:39 UTC) #3
jochen (gone - plz use gerrit)
I'm not sure I understand. for gamepads, we don't create a custom mock object, but ...
7 years, 7 months ago (2013-05-21 12:14:43 UTC) #4
timvolodine
On 2013/05/21 12:14:43, jochen wrote: > I'm not sure I understand. > > for gamepads, ...
7 years, 7 months ago (2013-05-21 12:17:41 UTC) #5
jochen (gone - plz use gerrit)
sorry, you're right What about Hyphenation or any of the other mocks we inject into ...
7 years, 7 months ago (2013-05-21 12:19:15 UTC) #6
timvolodine
On 2013/05/21 12:19:15, jochen wrote: > sorry, you're right > > What about Hyphenation or ...
7 years, 7 months ago (2013-05-21 12:27:44 UTC) #7
jochen (gone - plz use gerrit)
this CL is obsolete now, right?
7 years, 5 months ago (2013-07-25 13:12:02 UTC) #8
timvolodine
7 years, 5 months ago (2013-07-25 14:04:52 UTC) #9
On 2013/07/25 13:12:02, jochen wrote:
> this CL is obsolete now, right?

correct, I'll close it.

Powered by Google App Engine
This is Rietveld 408576698