Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1468173005: Revert of Remove SkFontConfigInterface race suppression. (Closed)

Created:
5 years ago by Alexander Potapenko
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove SkFontConfigInterface race suppression. (patchset #1 id:1 of https://codereview.chromium.org/1467313002/ ) Reason for revert: The data race is still reproducible (see the bug) BUG=chromium:369257 Original issue's description: > Remove SkFontConfigInterface race suppression. > > The race was fixed with https://codereview.chromium.org/355573006 , > committed as > https://skia.googlesource.com/skia/+/e438ddbc7451ec80f953266409fea4695e78c8c2 > > This is effectively a revert of https://codereview.chromium.org/273523002 . > > BUG=chromium:369257 > > Committed: https://crrev.com/a8c01b568251a5dc191e4fb67ab5c1dc6b8af86e > Cr-Commit-Position: refs/heads/master@{#361125} TBR=mtklein@chromium.org,bungeman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:369257 Committed: https://crrev.com/ac2843f9b9583ee6512cd1312ed416b7e884b92b Cr-Commit-Position: refs/heads/master@{#361323}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M build/sanitizers/tsan_suppressions.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexander Potapenko
Created Revert of Remove SkFontConfigInterface race suppression.
5 years ago (2015-11-24 12:16:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468173005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468173005/1
5 years ago (2015-11-24 12:16:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 12:17:07 UTC) #3
commit-bot: I haz the power
5 years ago (2015-11-24 12:18:06 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac2843f9b9583ee6512cd1312ed416b7e884b92b
Cr-Commit-Position: refs/heads/master@{#361323}

Powered by Google App Engine
This is Rietveld 408576698