Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 273523002: TSan v2: temporarily suppress a race in SkFontConfigInterface. (Closed)

Created:
6 years, 7 months ago by Jorge Lucangeli Obes
Modified:
6 years, 7 months ago
CC:
chromium-reviews_chromiu.org, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org, mtklein_C
Visibility:
Public.

Description

TSan v2: temporarily suppress a race in SkFontConfigInterface. SkFontConfigInterface::GetSingletonDirectInterface uses SkOnce. We need to teach TSan about SkOnce. BUG=369257 TEST=content_browsertests pass running under TSan. NOTRY=true TBR=glider@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268653

Patch Set 1 #

Patch Set 2 : Update one suppression. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tools/valgrind/tsan_v2/suppressions.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jorge Lucangeli Obes
The CQ bit was checked by jorgelo@chromium.org
6 years, 7 months ago (2014-05-07 01:22:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jorgelo@chromium.org/273523002/20001
6 years, 7 months ago (2014-05-07 01:23:56 UTC) #2
commit-bot: I haz the power
Change committed as 268653
6 years, 7 months ago (2014-05-07 01:28:19 UTC) #3
mtklein
6 years, 7 months ago (2014-05-07 14:27:28 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698