Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1468073004: Reshuffle registers in JSConstructStub to avoid trashing costructor and new.target on fast path (so… (Closed)

Created:
5 years ago by Igor Sheludko
Modified:
5 years ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reshuffle registers in JSConstructStub to avoid trashing costructor and new.target on fast path (so we don't need to push/pop them). This CL also fixed register usages in MacroAssembler::Allocate() broken by 2fc2cb99 (r32144). BUG=chromium:560239 LOG=Y Committed: https://crrev.com/0ef5ad5ab97657f7e3393be7512fef883b205c87 Cr-Commit-Position: refs/heads/master@{#32219}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -340 lines) Patch
M src/arm/builtins-arm.cc View 6 chunks +33 lines, -36 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 8 chunks +45 lines, -58 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 4 chunks +16 lines, -23 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 5 chunks +24 lines, -21 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/mips/builtins-mips.cc View 7 chunks +23 lines, -28 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 6 chunks +52 lines, -62 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 8 chunks +21 lines, -29 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 6 chunks +49 lines, -55 lines 0 comments Download
M src/x64/builtins-x64.cc View 5 chunks +33 lines, -24 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468073004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468073004/1
5 years ago (2015-11-24 11:32:33 UTC) #2
Igor Sheludko
PTAL
5 years ago (2015-11-24 11:49:52 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468073004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468073004/20001
5 years ago (2015-11-24 11:51:01 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-24 12:14:44 UTC) #9
Toon Verwaest
lgtm, much easier to read...
5 years ago (2015-11-24 14:55:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468073004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468073004/20001
5 years ago (2015-11-24 14:57:59 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years ago (2015-11-24 15:36:38 UTC) #14
commit-bot: I haz the power
5 years ago (2015-11-24 15:37:13 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ef5ad5ab97657f7e3393be7512fef883b205c87
Cr-Commit-Position: refs/heads/master@{#32219}

Powered by Google App Engine
This is Rietveld 408576698