ScopedPtrMap -> std::map from /component

ScopedPtrMap -> std::map from /component

C++ 11 enables containers that contain move-only type, scoped_ptr.
So, Use std::map<key, scoped_ptr<Foo>> instead of ScopedPtrMap.

BUG=554291
TBR=raymes@chromium.org

Committed: https://crrev.com/cdc9400e91c8d182af2b051724458049dd5bfeca
Cr-Commit-Position: refs/heads/master@{#361118}

[limasdf, 2015-11-23 11:53:26]

Description was changed from

==========
WIP


WIP

BUG=
==========

to

==========
ScopedPtrMap -> std::map from /component

C++ 11 enables containers that contain move-only type, scoped_ptr.
So, Use std::map<key, scoped_ptr<Foo>> instead of ScopedPtrMap.

BUG=554291
==========

[limasdf, 2015-11-23 11:53:26]

limasdf@gmail.com changed reviewers:
+ sdefresne@chromium.org

[limasdf, 2015-11-23 11:58:48]

Patchset #1 (id:1) has been deleted

[limasdf, 2015-11-23 12:00:05]

limasdf@gmail.com changed reviewers:
+ raymes@chromium.org

[limasdf, 2015-11-23 12:03:32]

Please take a look. thanks.

raymes for /chrome/browser/content_settings
sdefresne for /component

[sdefresne, 2015-11-23 13:28:13]

lgtm

https://codereview.chromium.org/1468013002/diff/20001/components/content_sett...
File components/content_settings/core/browser/content_settings_pref_provider.cc
(left):

https://codereview.chromium.org/1468013002/diff/20001/components/content_sett...
components/content_settings/core/browser/content_settings_pref_provider.cc:98:
content_settings_prefs_.set(
nit: I think the equivalent of ScopedPtrMap::set() is std::set::insert().

[limasdf, 2015-11-23 15:11:03]

Description was changed from

==========
ScopedPtrMap -> std::map from /component

C++ 11 enables containers that contain move-only type, scoped_ptr.
So, Use std::map<key, scoped_ptr<Foo>> instead of ScopedPtrMap.

BUG=554291
==========

to

==========
ScopedPtrMap -> std::map from /component

C++ 11 enables containers that contain move-only type, scoped_ptr.
So, Use std::map<key, scoped_ptr<Foo>> instead of ScopedPtrMap.

BUG=554291
TBR=raymes@chromium.org
==========

[limasdf, 2015-11-23 15:12:01]

TBRing
chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

Because it's simple enough. it->second  => it->second.get()

https://codereview.chromium.org/1468013002/diff/20001/components/content_sett...
File components/content_settings/core/browser/content_settings_pref_provider.cc
(left):

https://codereview.chromium.org/1468013002/diff/20001/components/content_sett...
components/content_settings/core/browser/content_settings_pref_provider.cc:98:
content_settings_prefs_.set(
On 2015/11/23 13:28:13, sdefresne wrote:
> nit: I think the equivalent of ScopedPtrMap::set() is std::set::insert().

Done.

[limasdf, 2015-11-23 15:12:05]

The CQ bit was checked by limasdf@gmail.com

[limasdf, 2015-11-23 15:12:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/1468013002/#ps40001
(title: "nit")

[commit-bot: I haz the power, 2015-11-23 15:12:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1468013002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1468013002/40001

[commit-bot: I haz the power, 2015-11-23 16:24:05]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-11-23 16:25:11]

Patchset 2 (id:??) landed as
https://crrev.com/cdc9400e91c8d182af2b051724458049dd5bfeca
Cr-Commit-Position: refs/heads/master@{#361118}