components/sync_driver/device_info_service.cc - Issue 1468013002: ScopedPtrMap -> std::map from /component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/device_info_service.cc

Issue 1468013002: ScopedPtrMap -> std::map from /component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync_driver/device_info_service.cc

diff --git a/components/sync_driver/device_info_service.cc b/components/sync_driver/device_info_service.cc

index fb4511290888074a27c5cc2d0705bea62fc5d753..29a4d19314808b6bc9f8b3208881028d18e740c7 100644

--- a/components/sync_driver/device_info_service.cc

+++ b/components/sync_driver/device_info_service.cc

@@ -179,8 +179,7 @@ void DeviceInfoService::StoreSpecifics(

scoped_ptr<DeviceInfoSpecifics> specifics) {

DVLOG(1) << "Storing DEVICE_INFO for " << specifics->client_name()

<< " with ID " << specifics->cache_guid();

- const std::string& key = specifics->cache_guid();

- all_data_.set(key, specifics.Pass());

+ all_data_[specifics->cache_guid()] = std::move(specifics);

}

void DeviceInfoService::DeleteSpecifics(const std::string& client_id) {

« no previous file with comments | « components/sync_driver/device_info_service.h ('k') | no next file » | no next file with comments »