Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: util/win/module_version.h

Issue 1467993003: win: Don't warn when no VERSIONINFO resource is present in a module (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | util/win/module_version.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/win/module_version.h
diff --git a/util/win/module_version.h b/util/win/module_version.h
index e7d37692bcacad6c46fecfa0fa4b5fdca539e496..be56eb9df9a2785c257b8880bee1c3a6509f4b10 100644
--- a/util/win/module_version.h
+++ b/util/win/module_version.h
@@ -25,10 +25,12 @@ namespace crashpad {
//! dll, etc.)
//!
//! \param[in] path The path to the module to be inspected.
-//! \param[out] vs_fixedfileinfo The VS_FIXEDFILEINFO on success. `dwFileFlags`
-//! will have been masked with `dwFileFlagsMask` already.
+//! \param[out] vs_fixedfileinfo The `VS_FIXEDFILEINFO` on success.
+//! `dwFileFlags` will have been masked with `dwFileFlagsMask` already.
//!
-//! \return `true` on success, or `false` on failure with a message logged.
+//! \return `true` on success, or `false` on failure with a message logged. If
+//! the module has no `VERSIONINFO` resource, `false` will be returned
+//! without any messages logged.
bool GetModuleVersionAndType(const base::FilePath& path,
VS_FIXEDFILEINFO* vs_fixedfileinfo);
« no previous file with comments | « no previous file | util/win/module_version.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698