Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Side by Side Diff: util/win/module_version.h

Issue 1467993003: win: Don't warn when no VERSIONINFO resource is present in a module (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | util/win/module_version.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Crashpad Authors. All rights reserved. 1 // Copyright 2015 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #ifndef CRASHPAD_UTIL_WIN_MODULE_VERSION_H_ 15 #ifndef CRASHPAD_UTIL_WIN_MODULE_VERSION_H_
16 #define CRASHPAD_UTIL_WIN_MODULE_VERSION_H_ 16 #define CRASHPAD_UTIL_WIN_MODULE_VERSION_H_
17 17
18 #include <windows.h> 18 #include <windows.h>
19 19
20 #include "base/files/file_path.h" 20 #include "base/files/file_path.h"
21 21
22 namespace crashpad { 22 namespace crashpad {
23 23
24 //! \brief Retrieve the type and version information from a given module (exe, 24 //! \brief Retrieve the type and version information from a given module (exe,
25 //! dll, etc.) 25 //! dll, etc.)
26 //! 26 //!
27 //! \param[in] path The path to the module to be inspected. 27 //! \param[in] path The path to the module to be inspected.
28 //! \param[out] vs_fixedfileinfo The VS_FIXEDFILEINFO on success. `dwFileFlags` 28 //! \param[out] vs_fixedfileinfo The `VS_FIXEDFILEINFO` on success.
29 //! will have been masked with `dwFileFlagsMask` already. 29 //! `dwFileFlags` will have been masked with `dwFileFlagsMask` already.
30 //! 30 //!
31 //! \return `true` on success, or `false` on failure with a message logged. 31 //! \return `true` on success, or `false` on failure with a message logged. If
32 //! the module has no `VERSIONINFO` resource, `false` will be returned
33 //! without any messages logged.
32 bool GetModuleVersionAndType(const base::FilePath& path, 34 bool GetModuleVersionAndType(const base::FilePath& path,
33 VS_FIXEDFILEINFO* vs_fixedfileinfo); 35 VS_FIXEDFILEINFO* vs_fixedfileinfo);
34 36
35 } // namespace crashpad 37 } // namespace crashpad
36 38
37 #endif // CRASHPAD_UTIL_WIN_MODULE_VERSION_H_ 39 #endif // CRASHPAD_UTIL_WIN_MODULE_VERSION_H_
OLDNEW
« no previous file with comments | « no previous file | util/win/module_version.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698