Issue 1467993003: win: Don't warn when no VERSIONINFO resource is present in a module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1467993003: win: Don't warn when no VERSIONINFO resource is present in a module (Closed)

Created:
5 years ago by Mark Mentovai

Modified:
5 years ago

Reviewers:
scottmg

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

win: Don't warn when no VERSIONINFO resource is present in a module Modules will work without a VERSIONINFO resource. This happens in some of Crashpad's tests. R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/116e1087f07727c98fc8c30afcc961216fd1b3a9

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -24 lines)			Patch
	M	util/win/module_version.h	View		1 chunk	+5 lines, -3 lines	0 comments	Download
	M	util/win/module_version.cc	View		1 chunk	+22 lines, -21 lines	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

5 years ago (2015-11-23 21:17:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
116e1087f07727c98fc8c30afcc961216fd1b3a9 (presubmit successful).