chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc - Issue 1467993002: Remove ManagePasswordsUIController::NavigateToSmartLockPage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

Issue 1467993002: Remove ManagePasswordsUIController::NavigateToSmartLockPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Switching infobars to non-localised link, moving kPasswordManagerAccountDashboardURL to components Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_bubble_model.cc ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

index b35b3386155e7af1336761bbcac43cd1d72b7d28..1cec681d9bf02360ba57291bb6b6afeb940ec2ca 100644

--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

@@ -83,7 +83,6 @@ class ManagePasswordsUIControllerMockWithMockNavigation

MOCK_METHOD0(NavigateToPasswordManagerSettingsPage, void());

MOCK_METHOD0(NavigateToExternalPasswordManager, void());

- MOCK_METHOD0(NavigateToSmartLockPage, void());

MOCK_METHOD0(NavigateToSmartLockHelpPage, void());

MOCK_CONST_METHOD0(GetCurrentInteractionStats,

password_manager::InteractionsStats*());

@@ -578,7 +577,7 @@ TEST_P(ManagePasswordsBubbleModelBrandLinkTest, OnBrandLinkClicked) {

switch (test_case.expected_target) {

case BrandLinkTarget::SMART_LOCK_HOME:

- EXPECT_CALL(*controller(), NavigateToSmartLockPage());

+ EXPECT_CALL(*controller(), NavigateToExternalPasswordManager());

break;

case BrandLinkTarget::SMART_LOCK_HELP:

EXPECT_CALL(*controller(), NavigateToSmartLockHelpPage());