chrome/browser/ui/passwords/manage_passwords_bubble_model.cc - Issue 1467993002: Remove ManagePasswordsUIController::NavigateToSmartLockPage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

Issue 1467993002: Remove ManagePasswordsUIController::NavigateToSmartLockPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Switching infobars to non-localised link, moving kPasswordManagerAccountDashboardURL to components Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_manager_infobar_delegate.cc ('k') | chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

index 6037e40ed1ce68f66dc3f388ad366cb26c1887be..a1abf306ae48bda47dfad3956c2798370e8de0b8 100644

--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

@@ -16,11 +16,11 @@

#include "chrome/browser/sync/profile_sync_service_factory.h"

#include "chrome/browser/ui/passwords/manage_passwords_view_utils.h"

#include "chrome/browser/ui/passwords/passwords_model_delegate.h"

-#include "chrome/common/url_constants.h"

#include "chrome/grit/chromium_strings.h"

#include "chrome/grit/generated_resources.h"

#include "components/browser_sync/browser/profile_sync_service.h"

#include "components/password_manager/core/browser/password_bubble_experiment.h"

+#include "components/password_manager/core/browser/password_manager_constants.h"

#include "components/password_manager/core/browser/password_store.h"

#include "components/password_manager/core/common/credential_manager_types.h"

#include "components/password_manager/core/common/password_manager_ui.h"

@@ -122,7 +122,7 @@ ManagePasswordsBubbleModel::ManagePasswordsBubbleModel(

if (GetSmartLockBrandingState(GetProfile()) ==

password_bubble_experiment::SmartLockBranding::FULL) {

std::string management_hostname =

- GURL(chrome::kPasswordManagerAccountDashboardURL).host();

+ GURL(password_manager::kPasswordManagerAccountDashboardURL).host();

save_confirmation_link = base::UTF8ToUTF16(management_hostname);

confirmation_text_id =

IDS_MANAGE_PASSWORDS_CONFIRM_GENERATED_SMART_LOCK_TEXT;

@@ -315,7 +315,7 @@ void ManagePasswordsBubbleModel::OnBrandLinkClicked() {

switch (GetSmartLockBrandingState(GetProfile())) {

case password_bubble_experiment::SmartLockBranding::FULL:

PasswordsModelDelegateFromWebContents(web_contents())

- ->NavigateToSmartLockPage();

+ ->NavigateToExternalPasswordManager();

break;

case password_bubble_experiment::SmartLockBranding::SAVE_BUBBLE_ONLY:

PasswordsModelDelegateFromWebContents(web_contents())