chrome/browser/password_manager/generated_password_saved_infobar_delegate_android.cc - Issue 1467993002: Remove ManagePasswordsUIController::NavigateToSmartLockPage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/generated_password_saved_infobar_delegate_android.cc

Issue 1467993002: Remove ManagePasswordsUIController::NavigateToSmartLockPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Switching infobars to non-localised link, moving kPasswordManagerAccountDashboardURL to components Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/password_ui_view_android.cc ('k') | chrome/browser/password_manager/password_manager_infobar_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/generated_password_saved_infobar_delegate_android.cc

diff --git a/chrome/browser/password_manager/generated_password_saved_infobar_delegate_android.cc b/chrome/browser/password_manager/generated_password_saved_infobar_delegate_android.cc

index e1bbe5ee5155fe22a3bfd32de10f38e80b8c4b90..4a2a8c1fac66a7e78b30f31937b30f7b737addae 100644

--- a/chrome/browser/password_manager/generated_password_saved_infobar_delegate_android.cc

+++ b/chrome/browser/password_manager/generated_password_saved_infobar_delegate_android.cc

@@ -11,11 +11,11 @@

#include "chrome/browser/infobars/infobar_service.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/sync/profile_sync_service_factory.h"

-#include "chrome/common/url_constants.h"

#include "chrome/grit/generated_resources.h"

#include "chrome/grit/theme_resources.h"

#include "components/browser_sync/browser/profile_sync_service.h"

#include "components/password_manager/core/browser/password_bubble_experiment.h"

+#include "components/password_manager/core/browser/password_manager_constants.h"

#include "content/public/browser/web_contents.h"

#include "ui/base/l10n/l10n_util.h"

@@ -24,11 +24,11 @@ GeneratedPasswordSavedInfoBarDelegateAndroid::

void GeneratedPasswordSavedInfoBarDelegateAndroid::OnInlineLinkClicked() {

if (smart_lock_branding_enabled_) {

- InfoBarService::WebContentsFromInfoBar(infobar())->OpenURL(

- content::OpenURLParams(

- GURL(chrome::kPasswordManagerAccountDashboardURL),

- content::Referrer(), NEW_FOREGROUND_TAB,

- ui::PAGE_TRANSITION_LINK, false));

+ InfoBarService::WebContentsFromInfoBar(infobar())

+ ->OpenURL(content::OpenURLParams(

+ GURL(password_manager::kPasswordManagerAccountDashboardURL),

+ content::Referrer(), NEW_FOREGROUND_TAB, ui::PAGE_TRANSITION_LINK,

+ false));

} else {

chrome::android::ChromeApplication::ShowPasswordSettings();

}

@@ -49,7 +49,7 @@ GeneratedPasswordSavedInfoBarDelegateAndroid::

int confirmation_id = IDS_MANAGE_PASSWORDS_CONFIRM_GENERATED_TEXT_INFOBAR;

if (smart_lock_branding_enabled_) {

std::string management_hostname =

- GURL(chrome::kPasswordManagerAccountDashboardURL).host();

+ GURL(password_manager::kPasswordManagerAccountDashboardURL).host();

link = base::UTF8ToUTF16(management_hostname);

confirmation_id =

IDS_MANAGE_PASSWORDS_CONFIRM_GENERATED_SMART_LOCK_TEXT_INFOBAR;