chrome/browser/android/password_ui_view_android.cc - Issue 1467993002: Remove ManagePasswordsUIController::NavigateToSmartLockPage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/password_ui_view_android.cc

Issue 1467993002: Remove ManagePasswordsUIController::NavigateToSmartLockPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Switching infobars to non-localised link, moving kPasswordManagerAccountDashboardURL to components Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/password_manager/generated_password_saved_infobar_delegate_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/password_ui_view_android.cc

diff --git a/chrome/browser/android/password_ui_view_android.cc b/chrome/browser/android/password_ui_view_android.cc

index 37e7d34b2b2a48548eff89dd6960fd0bc28176d4..2542def6de4413c398ca630fa7c9535e57eeafba 100644

--- a/chrome/browser/android/password_ui_view_android.cc

+++ b/chrome/browser/android/password_ui_view_android.cc

@@ -12,11 +12,11 @@

#include "chrome/browser/profiles/profile_manager.h"

#include "chrome/browser/sync/profile_sync_service_factory.h"

#include "chrome/common/pref_names.h"

-#include "chrome/common/url_constants.h"

#include "components/autofill/core/common/password_form.h"

#include "components/browser_sync/browser/profile_sync_service.h"

#include "components/password_manager/core/browser/affiliation_utils.h"

#include "components/password_manager/core/browser/password_bubble_experiment.h"

+#include "components/password_manager/core/browser/password_manager_constants.h"

#include "components/password_manager/core/common/experiments.h"

#include "components/password_manager/core/common/password_manager_switches.h"

#include "jni/PasswordUIView_jni.h"

@@ -114,8 +114,8 @@ void PasswordUIViewAndroid::HandleRemoveSavedPasswordException(

ScopedJavaLocalRef<jstring> GetAccountDashboardURL(

JNIEnv* env,

const JavaParamRef<jclass>&) {

- return ConvertUTF8ToJavaString(env,

- chrome::kPasswordManagerAccountDashboardURL);

+ return ConvertUTF8ToJavaString(

+ env, password_manager::kPasswordManagerAccountDashboardURL);

}

static jboolean ShouldUseSmartLockBranding(JNIEnv* env,