Issue 1467733002: Revert "Remove WorldImpact from caches when no longer needed."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1467733002: Revert "Remove WorldImpact from caches when no longer needed." (Closed)

Created:
5 years, 1 month ago by sra1

Modified:
5 years, 1 month ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Remove WorldImpact from caches when no longer needed." Revert while breakage can be investigated TBR=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/b28df3dc5d1026f4b7bbe8e41a542e79b4860656

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -304 lines)			Patch
M	pkg/compiler/lib/src/common/backend_api.dart	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	pkg/compiler/lib/src/common/codegen.dart	View	3 chunks	+4 lines, -9 lines	0 comments	Download
M	pkg/compiler/lib/src/common/resolution.dart	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	pkg/compiler/lib/src/compiler.dart	View	4 chunks	+0 lines, -13 lines	0 comments	Download
M	pkg/compiler/lib/src/deferred_load.dart	View	4 chunks	+25 lines, -36 lines	0 comments	Download
M	pkg/compiler/lib/src/dump_info.dart	View	3 chunks	+20 lines, -49 lines	0 comments	Download
M	pkg/compiler/lib/src/enqueue.dart	View	7 chunks	+6 lines, -41 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/backend.dart	View	3 chunks	+1 line, -51 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/js_backend.dart	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	pkg/compiler/lib/src/universe/world_impact.dart	View	3 chunks	+0 lines, -81 lines	0 comments	Download

Total messages: 2 (0 generated)

sra1

Committed patchset #1 (id:1) manually as b28df3dc5d1026f4b7bbe8e41a542e79b4860656 (presubmit successful).

5 years, 1 month ago (2015-11-20 23:23:26 UTC) #1

Message was sent while issue was closed.

LGTM, sorry for the prolonged redness.