Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: pkg/compiler/lib/src/compiler.dart

Issue 1467733002: Revert "Remove WorldImpact from caches when no longer needed." (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/common/resolution.dart ('k') | pkg/compiler/lib/src/deferred_load.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/compiler.dart
diff --git a/pkg/compiler/lib/src/compiler.dart b/pkg/compiler/lib/src/compiler.dart
index 79bb08ecf0c5ddfed14ac90f4f893fefa0961dff..392b2026b6fc8cbf6e8d66de3db1a9ca40e7f80d 100644
--- a/pkg/compiler/lib/src/compiler.dart
+++ b/pkg/compiler/lib/src/compiler.dart
@@ -137,7 +137,6 @@ import 'universe/universe.dart' show
import 'universe/use.dart' show
StaticUse;
import 'universe/world_impact.dart' show
- ImpactStrategy,
WorldImpact;
import 'util/util.dart' show
Link,
@@ -158,8 +157,6 @@ abstract class Compiler {
final CacheStrategy cacheStrategy;
- ImpactStrategy impactStrategy = const ImpactStrategy();
-
/**
* Map from token to the first preceding comment token.
*/
@@ -978,9 +975,6 @@ abstract class Compiler {
// something to the resolution queue. So we cannot wait with
// this until after the resolution queue is processed.
deferredLoadTask.beforeResolution(this);
- impactStrategy = backend.createImpactStrategy(
- supportDeferredLoad: deferredLoadTask.isProgramSplit,
- supportDumpInfo: dumpInfo);
phase = PHASE_RESOLVING;
if (analyzeAll) {
@@ -2025,13 +2019,6 @@ class _CompilerResolution implements Resolution {
}
@override
- void uncacheWorldImpact(Element element) {
- assert(invariant(element, _worldImpactCache[element] != null,
- message: "WorldImpact not computed for $element."));
- _worldImpactCache[element] = const WorldImpact();
- }
-
- @override
bool hasBeenResolved(Element element) {
return _worldImpactCache.containsKey(element);
}
« no previous file with comments | « pkg/compiler/lib/src/common/resolution.dart ('k') | pkg/compiler/lib/src/deferred_load.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698