Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: net/http/http_transaction_test_util.cc

Issue 1467603002: URLRequestJob: change ReadRawData contract (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/services/network/url_loader_impl_apptest.cc ('k') | net/test/url_request/url_request_failed_job.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_transaction_test_util.cc
diff --git a/net/http/http_transaction_test_util.cc b/net/http/http_transaction_test_util.cc
index 6bd8230c46363c106a347badef77bfe6a7f8c7e1..13df9f6cdd120cf96b54d034e20aaec091c00364 100644
--- a/net/http/http_transaction_test_util.cc
+++ b/net/http/http_transaction_test_util.cc
@@ -211,6 +211,7 @@ void TestTransactionConsumer::DidFinish(int result) {
}
void TestTransactionConsumer::Read() {
+ CHECK(!done_reading_called_);
xunjieli 2015/11/23 15:37:56 I can't add CHECK(!done_reading_called_) here, bec
mmenke 2015/11/23 16:06:02 Sorry, I meant in MockNetworkTransaction::Read.
xunjieli 2015/11/23 16:15:58 Sorry, I meant to say it is a member of MockNetwor
state_ = READING;
read_buf_ = new IOBuffer(1024);
int result = trans_->Read(read_buf_.get(),
@@ -506,6 +507,7 @@ MockNetworkLayer::MockNetworkLayer()
MockNetworkLayer::~MockNetworkLayer() {}
void MockNetworkLayer::TransactionDoneReading() {
+ CHECK(!done_reading_called_);
done_reading_called_ = true;
}
« no previous file with comments | « mojo/services/network/url_loader_impl_apptest.cc ('k') | net/test/url_request/url_request_failed_job.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698