URLRequestJob: change ReadRawData contract

net/http/http_transaction_test_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_transaction_test_util.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/location.h"
@@ skipping 193 matching lines @@
 }
 
 void TestTransactionConsumer::DidFinish(int result) {
   state_ = DONE;
   error_ = result;
   if (--quit_counter_ == 0)
     base::MessageLoop::current()->QuitWhenIdle();
 }
 
 void TestTransactionConsumer::Read() {
+  CHECK(!done_reading_called_);

[xunjieli, 2015/11/23 15:37:56]

I can't add CHECK(!done_reading_called_) here, because done_reading_called is a
member of MockNetworkTransaction.

[mmenke, 2015/11/23 16:06:02]

Sorry, I meant in MockNetworkTransaction::Read.

[xunjieli, 2015/11/23 16:15:58]

Sorry, I meant to say it is a member of MockNetworkLayer. I have added a
done_reading_called_ to MockNetworkTransaction.

   state_ = READING;
   read_buf_ = new IOBuffer(1024);
   int result = trans_->Read(read_buf_.get(),
                             1024,
                             base::Bind(&TestTransactionConsumer::OnIOComplete,
                                        base::Unretained(this)));
   if (result != ERR_IO_PENDING)
     DidRead(result);
 }
 
@@ skipping 275 matching lines @@
     : transaction_count_(0),
       done_reading_called_(false),
       stop_caching_called_(false),
       last_create_transaction_priority_(DEFAULT_PRIORITY),
       clock_(nullptr) {
 }
 
 MockNetworkLayer::~MockNetworkLayer() {}
 
 void MockNetworkLayer::TransactionDoneReading() {
+  CHECK(!done_reading_called_);
   done_reading_called_ = true;
 }
 
 void MockNetworkLayer::TransactionStopCaching() {
   stop_caching_called_ = true;
 }
 
 int MockNetworkLayer::CreateTransaction(RequestPriority priority,
                                         scoped_ptr<HttpTransaction>* trans) {
   transaction_count_++;
@@ skipping 43 matching lines @@
       content.append(buf->data(), rv);
     else if (rv < 0)
       return rv;
   } while (rv > 0);
 
   result->swap(content);
   return OK;
 }
 
 }  // namespace net