Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3154)

Unified Diff: chrome/browser/download/download_resource_throttle_unittest.cc

Issue 1467563002: Use ResourceRequestInfo::GetWebContents in DownloadRequestLimiter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@web-contents-callback
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_resource_throttle_unittest.cc
diff --git a/chrome/browser/download/download_resource_throttle_unittest.cc b/chrome/browser/download/download_resource_throttle_unittest.cc
index 20ac74d7c6085d57679200aef375310a25695ed6..4d270a5e5e59d78cde4479b83497013e925cdcf0 100644
--- a/chrome/browser/download/download_resource_throttle_unittest.cc
+++ b/chrome/browser/download/download_resource_throttle_unittest.cc
@@ -47,6 +47,14 @@ ACTION_P(QuitLoop, quit_closure) {
quit_closure);
}
+content::WebContents* GetWebContents(int process_id, int render_view_id) {
+ content::RenderViewHost* render_view_host =
+ content::RenderViewHost::FromID(process_id, render_view_id);
+ if (!render_view_host)
+ return nullptr;
+ return content::WebContents::FromRenderViewHost(render_view_host);
+}
+
class DownloadResourceThrottleTest : public ChromeRenderViewHostTestHarness {
public:
DownloadResourceThrottleTest()
@@ -78,7 +86,8 @@ class DownloadResourceThrottleTest : public ChromeRenderViewHostTestHarness {
void StartThrottleOnIOThread(int process_id, int render_view_id) {
throttle_ = new DownloadResourceThrottle(
- limiter_, process_id, render_view_id, GURL(kTestUrl), "GET");
+ limiter_, base::Bind(&GetWebContents, process_id, render_view_id),
davidben 2015/11/24 15:51:16 There's a tab_util::GetWebContentsByID you could u
clamy 2015/11/25 14:02:02 Done.
+ GURL(kTestUrl), "GET");
throttle_->set_controller_for_testing(&resource_controller_);
bool defer;
throttle_->WillStartRequest(&defer);

Powered by Google App Engine
This is Rietveld 408576698