Use ResourceRequestInfo::GetWebContents in DownloadRequestLimiter

chrome/browser/download/download_resource_throttle_unittest.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/run_loop.h"
 #include "chrome/browser/download/download_request_limiter.h"
 #include "chrome/browser/download/download_resource_throttle.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "content/public/browser/browser_thread.h"
@@ skipping 29 matching lines @@
   MOCK_METHOD1(CancelWithError, void(int));
   MOCK_METHOD0(Resume, void());
 };
 
 // Posts |quit_closure| to UI thread.
 ACTION_P(QuitLoop, quit_closure) {
   content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
                                    quit_closure);
 }
 
+content::WebContents* GetWebContents(int process_id, int render_view_id) {
+  content::RenderViewHost* render_view_host =
+      content::RenderViewHost::FromID(process_id, render_view_id);
+  if (!render_view_host)
+    return nullptr;
+  return content::WebContents::FromRenderViewHost(render_view_host);
+}
+
 class DownloadResourceThrottleTest : public ChromeRenderViewHostTestHarness {
  public:
   DownloadResourceThrottleTest()
       : throttle_(nullptr), limiter_(new DownloadRequestLimiter()) {
     // Cannot use IO_MAIN_LOOP with RenderViewHostTestHarness.
     SetThreadBundleOptions(content::TestBrowserThreadBundle::REAL_IO_THREAD);
   }
 
   ~DownloadResourceThrottleTest() override {}
 
@@ skipping 11 matching lines @@
     content::BrowserThread::DeleteSoon(content::BrowserThread::IO, FROM_HERE,
                                        throttle_);
 #if defined(OS_ANDROID)
     content::DownloadControllerAndroid::SetDownloadControllerAndroid(nullptr);
 #endif
     ChromeRenderViewHostTestHarness::TearDown();
   }
 
   void StartThrottleOnIOThread(int process_id, int render_view_id) {
     throttle_ = new DownloadResourceThrottle(
-        limiter_, process_id, render_view_id, GURL(kTestUrl), "GET");
+        limiter_, base::Bind(&GetWebContents, process_id, render_view_id),

[davidben, 2015/11/24 15:51:16]

There's a tab_util::GetWebContentsByID you could use instead.

[clamy, 2015/11/25 14:02:02]

Done.

+        GURL(kTestUrl), "GET");
     throttle_->set_controller_for_testing(&resource_controller_);
     bool defer;
     throttle_->WillStartRequest(&defer);
     EXPECT_EQ(true, defer);
   }
 
   void StartThrottle() {
     content::BrowserThread::PostTask(
         content::BrowserThread::IO, FROM_HERE,
         base::Bind(&DownloadResourceThrottleTest::StartThrottleOnIOThread,
@@ skipping 22 matching lines @@
 
 #if defined(OS_ANDROID)
 TEST_F(DownloadResourceThrottleTest, DownloadWithFailedFileAcecssRequest) {
   content::DownloadControllerAndroid::Get()
       ->SetApproveFileAccessRequestForTesting(false);
   EXPECT_CALL(resource_controller_, Cancel())
       .WillOnce(QuitLoop(run_loop_->QuitClosure()));
   StartThrottle();
 }
 #endif