Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1467553002: New API for computing optimization invariants. (Closed)

Created:
5 years, 1 month ago by ethannicholas
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

New API for computing optimization invariants. Committed: https://skia.googlesource.com/skia/+/ff2103200bad7abcf8929ae22ac78a9f4f725142

Patch Set 1 #

Patch Set 2 : #

Total comments: 9

Patch Set 3 : #

Total comments: 7

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+416 lines, -422 lines) Patch
M src/gpu/GrDrawTarget.cpp View 1 2 3 1 chunk +8 lines, -4 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 2 5 chunks +60 lines, -56 lines 0 comments Download
M src/gpu/GrPathProcessor.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrPathProcessor.cpp View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/GrPipeline.h View 1 2 3 2 chunks +12 lines, -3 lines 0 comments Download
M src/gpu/GrPipeline.cpp View 1 2 3 4 chunks +28 lines, -27 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 1 2 2 chunks +2 lines, -25 lines 0 comments Download
M src/gpu/GrPipelineBuilder.cpp View 1 2 3 1 chunk +0 lines, -13 lines 0 comments Download
M src/gpu/GrPrimitiveProcessor.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrProcOptInfo.h View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M src/gpu/GrProcOptInfo.cpp View 1 2 chunks +8 lines, -18 lines 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 1 2 1 chunk +13 lines, -12 lines 0 comments Download
M src/gpu/batches/GrAADistanceFieldPathRenderer.cpp View 1 2 1 chunk +12 lines, -12 lines 0 comments Download
M src/gpu/batches/GrAAFillRectBatch.cpp View 1 2 9 chunks +21 lines, -21 lines 0 comments Download
M src/gpu/batches/GrAAHairLinePathRenderer.cpp View 1 2 1 chunk +12 lines, -11 lines 0 comments Download
M src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp View 1 2 1 chunk +13 lines, -12 lines 0 comments Download
M src/gpu/batches/GrAAStrokeRectBatch.cpp View 1 2 3 chunks +14 lines, -14 lines 0 comments Download
M src/gpu/batches/GrAtlasTextBatch.h View 1 2 2 chunks +7 lines, -5 lines 0 comments Download
M src/gpu/batches/GrAtlasTextBatch.cpp View 1 2 1 chunk +15 lines, -16 lines 0 comments Download
M src/gpu/batches/GrDefaultPathRenderer.cpp View 1 2 3 4 1 chunk +12 lines, -11 lines 0 comments Download
M src/gpu/batches/GrDrawAtlasBatch.h View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/batches/GrDrawAtlasBatch.cpp View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/batches/GrDrawBatch.h View 1 2 3 2 chunks +10 lines, -3 lines 0 comments Download
M src/gpu/batches/GrDrawBatch.cpp View 1 2 3 1 chunk +11 lines, -3 lines 0 comments Download
M src/gpu/batches/GrDrawPathBatch.h View 1 2 2 chunks +11 lines, -11 lines 0 comments Download
M src/gpu/batches/GrDrawPathBatch.cpp View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/batches/GrDrawVerticesBatch.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/batches/GrDrawVerticesBatch.cpp View 1 2 1 chunk +11 lines, -11 lines 0 comments Download
M src/gpu/batches/GrNinePatch.cpp View 1 2 4 chunks +13 lines, -13 lines 0 comments Download
M src/gpu/batches/GrNonAAFillRectBatch.cpp View 1 2 5 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/batches/GrNonAAStrokeRectBatch.cpp View 1 2 2 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/batches/GrTInstanceBatch.h View 1 2 6 chunks +19 lines, -18 lines 0 comments Download
M src/gpu/batches/GrTessellatingPathRenderer.cpp View 1 2 2 chunks +11 lines, -11 lines 0 comments Download
M src/gpu/batches/GrTestBatch.h View 1 2 1 chunk +12 lines, -12 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 2 2 chunks +12 lines, -11 lines 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 2 3 1 chunk +12 lines, -11 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
ethannicholas
5 years, 1 month ago (2015-11-20 17:04:50 UTC) #2
ethannicholas
5 years, 1 month ago (2015-11-23 18:58:31 UTC) #3
joshualitt
https://codereview.chromium.org/1467553002/diff/20001/include/gpu/GrInvariantOutput.h File include/gpu/GrInvariantOutput.h (right): https://codereview.chromium.org/1467553002/diff/20001/include/gpu/GrInvariantOutput.h#newcode257 include/gpu/GrInvariantOutput.h:257: friend class GrPipelineBuilder; Uneccessary https://codereview.chromium.org/1467553002/diff/20001/src/gpu/GrDrawTarget.cpp File src/gpu/GrDrawTarget.cpp (right): https://codereview.chromium.org/1467553002/diff/20001/src/gpu/GrDrawTarget.cpp#newcode537 ...
5 years, 1 month ago (2015-11-23 19:09:29 UTC) #5
ethannicholas
5 years, 1 month ago (2015-11-23 22:07:55 UTC) #6
egdaniel
https://codereview.chromium.org/1467553002/diff/40001/src/gpu/GrDrawTarget.cpp File src/gpu/GrDrawTarget.cpp (right): https://codereview.chromium.org/1467553002/diff/40001/src/gpu/GrDrawTarget.cpp#newcode547 src/gpu/GrDrawTarget.cpp:547: args.fColorPOI = opt.fColorPOI; shouldn't the CreateArgs just take a ...
5 years, 1 month ago (2015-11-24 00:08:14 UTC) #7
ethannicholas
https://codereview.chromium.org/1467553002/diff/40001/src/gpu/GrPipelineBuilder.h File src/gpu/GrPipelineBuilder.h (right): https://codereview.chromium.org/1467553002/diff/40001/src/gpu/GrPipelineBuilder.h#newcode385 src/gpu/GrPipelineBuilder.h:385: friend class GrDrawTarget; On 2015/11/24 00:08:14, egdaniel wrote: > ...
5 years ago (2015-11-24 14:53:51 UTC) #8
egdaniel
this lgtm but might want to get Josh's approval as well
5 years ago (2015-11-24 17:27:56 UTC) #9
joshualitt
On 2015/11/24 17:27:56, egdaniel wrote: > this lgtm but might want to get Josh's approval ...
5 years ago (2015-11-24 17:43:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467553002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467553002/60001
5 years ago (2015-11-24 19:43:18 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-x86_64-Release-Trybot/builds/6849)
5 years ago (2015-11-24 19:45:30 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467553002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467553002/80001
5 years ago (2015-11-24 19:52:58 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-24 20:06:19 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467553002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467553002/80001
5 years ago (2015-11-24 20:09:14 UTC) #21
commit-bot: I haz the power
5 years ago (2015-11-24 20:10:13 UTC) #22
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/ff2103200bad7abcf8929ae22ac78a9f4f725142

Powered by Google App Engine
This is Rietveld 408576698