content/child/web_memory_dump_provider_adapter.cc - Issue 1467453003: [Tracing] Make heap profiler type info a string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/web_memory_dump_provider_adapter.cc

Issue 1467453003: [Tracing] Make heap profiler type info a string (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/child/web_memory_dump_provider_adapter.cc

diff --git a/content/child/web_memory_dump_provider_adapter.cc b/content/child/web_memory_dump_provider_adapter.cc

index b0a8a6a3cc29d01d5fdb9147ac66804e2dc03c6d..84f709948c96e49da94a251df764c7e86bc349a2 100644

--- a/content/child/web_memory_dump_provider_adapter.cc

+++ b/content/child/web_memory_dump_provider_adapter.cc

@@ -76,7 +76,8 @@ bool WebMemoryDumpProviderAdapter::OnMemoryDump(

if (args.level_of_detail == MemoryDumpLevelOfDetail::DETAILED &&

web_memory_dump_provider_->supportsHeapProfiling() &&

g_heap_profiling_enabled) {

- HeapDumpWriter writer(pmd->session_state()->stack_frame_deduplicator());

+ HeapDumpWriter writer(pmd->session_state()->stack_frame_deduplicator(),

+ pmd->session_state()->type_name_deduplicator());

TraceEventMemoryOverhead overhead;

{