base/trace_event/winheap_dump_provider_win_unittest.cc - Issue 1467453003: [Tracing] Make heap profiler type info a string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/winheap_dump_provider_win_unittest.cc

Issue 1467453003: [Tracing] Make heap profiler type info a string (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/winheap_dump_provider_win_unittest.cc

diff --git a/base/trace_event/winheap_dump_provider_win_unittest.cc b/base/trace_event/winheap_dump_provider_win_unittest.cc

index fac002f4845bbf8fb27ded0b0846a8333ac02b73..c74a7b7bc82d41da134f29ec1392103169bdb4b7 100644

--- a/base/trace_event/winheap_dump_provider_win_unittest.cc

+++ b/base/trace_event/winheap_dump_provider_win_unittest.cc

@@ -14,7 +14,7 @@ namespace base {

namespace trace_event {

TEST(WinHeapDumpProviderTest, OnMemoryDump) {

- ProcessMemoryDump pmd(new MemoryDumpSessionState(nullptr));

+ ProcessMemoryDump pmd(new MemoryDumpSessionState(nullptr, nullptr));

MemoryDumpArgs dump_args = {MemoryDumpLevelOfDetail::DETAILED};

WinHeapDumpProvider* winheap_dump_provider =