Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 14674004: DRAFT: Add setKeyboardVisibility API. (Closed)

Created:
7 years, 7 months ago by bryeung
Modified:
7 years, 5 months ago
Reviewers:
sadrul
CC:
chromium-reviews, Aaron Boodman, sadrul, chromium-apps-reviews_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Add setKeyboardVisibility API. This allows the visibility of the API to be controlled directly from extensions requesting the API, and allows the "hide keyboard" button to be implemented. BUG=236925

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -34 lines) Patch
M ash/root_window_controller.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/shell.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ash/shell.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/input/input.h View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/input/input.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_function_histogram_value.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental_input_virtual_keyboard.json View 1 chunk +11 lines, -0 lines 0 comments Download
M ui/keyboard/keyboard_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/keyboard/keyboard_controller.cc View 2 chunks +31 lines, -31 lines 2 comments Download
M ui/keyboard/keyboard_ui_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/keyboard/keyboard_ui_handler.cc View 2 chunks +15 lines, -0 lines 2 comments Download
M ui/keyboard/resources/api_adapter.js View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/keyboard/resources/common.js View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/keyboard/resources/layout_us.js View 1 chunk +2 lines, -1 line 0 comments Download
M ui/keyboard/resources/webui/api_adapter.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
bryeung
Sadrul: this CL still has a couple of issues, but I'd like to get your ...
7 years, 7 months ago (2013-04-30 20:21:03 UTC) #1
sadrul
7 years, 7 months ago (2013-05-14 06:23:19 UTC) #2
> - hiding from the app-list causes the app-list to lose focus

Perhaps because this causes the app-list window to move?

https://codereview.chromium.org/14674004/diff/1/ui/keyboard/keyboard_controll...
File ui/keyboard/keyboard_controller.cc (right):

https://codereview.chromium.org/14674004/diff/1/ui/keyboard/keyboard_controll...
ui/keyboard/keyboard_controller.cc:170: container_->Hide();
On 2013/04/30 20:21:03, bryeung wrote:
> directly hiding the keyboard from JS seems to cause jank: the animation on the
> button looks to still be in progress when the keyboard is shown again.  Any
idea
> what's going on with that?

Animation in the page itself should not be causing the window-hide to jank.
Something is probably doing bad things, but I can't think of what it might be.

https://codereview.chromium.org/14674004/diff/1/ui/keyboard/keyboard_ui_handl...
File ui/keyboard/keyboard_ui_handler.cc (right):

https://codereview.chromium.org/14674004/diff/1/ui/keyboard/keyboard_ui_handl...
ui/keyboard/keyboard_ui_handler.cc:30: "setKeyboardVisibility",
Will this be ever used to show the keyboard? i.e. will the keyboard JS be able
to show itself while it was hidden? If it does, what would be the target of the
key events (e.g. no view/window is currently focused, or if the focused
view/window does not accept text input etc.)?

https://codereview.chromium.org/14674004/diff/1/ui/keyboard/keyboard_ui_handl...
ui/keyboard/keyboard_ui_handler.cc:46: // TODO(sadrul): get the
KeyboardController without using the Shell
I can't think of a good way of doing this. One option would be to remove the
focus from the currently focused view/window, when the visibility is changing to
hidden.

Powered by Google App Engine
This is Rietveld 408576698