src/a64/assembler-a64.cc - Issue 146733004: A64: Make 'debug BREAK' instructions halt on real hardware.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/a64/assembler-a64.cc

Issue 146733004: A64: Make 'debug BREAK' instructions halt on real hardware. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/a64/assembler-a64.cc

diff --git a/src/a64/assembler-a64.cc b/src/a64/assembler-a64.cc

index 4aee4182c1c84169883b19420e16f1c95540762b..08469444d97470ea847bb70a856652306ea98409 100644

--- a/src/a64/assembler-a64.cc

+++ b/src/a64/assembler-a64.cc

@@ -1808,6 +1808,10 @@ void Assembler::debug(const char* message, uint32_t code, Instr params) {

ASSERT(SizeOfCodeGeneratedSince(&start) == kDebugMessageOffset);

EmitStringData(message);

hlt(kImmExceptionIsUnreachable);

+#else

+ if (params & BREAK) {

+ hlt(kImmExceptionIsDebug);

+ }

#endif

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »