Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Side by Side Diff: src/a64/assembler-a64.cc

Issue 146733004: A64: Make 'debug BREAK' instructions halt on real hardware. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // 2 //
3 // Redistribution and use in source and binary forms, with or without 3 // Redistribution and use in source and binary forms, with or without
4 // modification, are permitted provided that the following conditions are 4 // modification, are permitted provided that the following conditions are
5 // met: 5 // met:
6 // 6 //
7 // * Redistributions of source code must retain the above copyright 7 // * Redistributions of source code must retain the above copyright
8 // notice, this list of conditions and the following disclaimer. 8 // notice, this list of conditions and the following disclaimer.
9 // * Redistributions in binary form must reproduce the above 9 // * Redistributions in binary form must reproduce the above
10 // copyright notice, this list of conditions and the following 10 // copyright notice, this list of conditions and the following
(...skipping 1790 matching lines...) Expand 10 before | Expand all | Expand 10 after
1801 // Refer to instructions-a64.h for a description of the marker and its 1801 // Refer to instructions-a64.h for a description of the marker and its
1802 // arguments. 1802 // arguments.
1803 hlt(kImmExceptionIsDebug); 1803 hlt(kImmExceptionIsDebug);
1804 ASSERT(SizeOfCodeGeneratedSince(&start) == kDebugCodeOffset); 1804 ASSERT(SizeOfCodeGeneratedSince(&start) == kDebugCodeOffset);
1805 dc32(code); 1805 dc32(code);
1806 ASSERT(SizeOfCodeGeneratedSince(&start) == kDebugParamsOffset); 1806 ASSERT(SizeOfCodeGeneratedSince(&start) == kDebugParamsOffset);
1807 dc32(params); 1807 dc32(params);
1808 ASSERT(SizeOfCodeGeneratedSince(&start) == kDebugMessageOffset); 1808 ASSERT(SizeOfCodeGeneratedSince(&start) == kDebugMessageOffset);
1809 EmitStringData(message); 1809 EmitStringData(message);
1810 hlt(kImmExceptionIsUnreachable); 1810 hlt(kImmExceptionIsUnreachable);
1811 #else
1812 if (params & BREAK) {
1813 hlt(kImmExceptionIsDebug);
1814 }
1811 #endif 1815 #endif
1812 } 1816 }
1813 1817
1814 1818
1815 void Assembler::Logical(const Register& rd, 1819 void Assembler::Logical(const Register& rd,
1816 const Register& rn, 1820 const Register& rn,
1817 const Operand& operand, 1821 const Operand& operand,
1818 LogicalOp op) { 1822 LogicalOp op) {
1819 ASSERT(rd.SizeInBits() == rn.SizeInBits()); 1823 ASSERT(rd.SizeInBits() == rn.SizeInBits());
1820 ASSERT(!operand.NeedsRelocation()); 1824 ASSERT(!operand.NeedsRelocation());
(...skipping 684 matching lines...) Expand 10 before | Expand all | Expand 10 after
2505 // code. 2509 // code.
2506 #ifdef ENABLE_DEBUGGER_SUPPORT 2510 #ifdef ENABLE_DEBUGGER_SUPPORT
2507 RecordRelocInfo(RelocInfo::CONST_POOL, static_cast<intptr_t>(size)); 2511 RecordRelocInfo(RelocInfo::CONST_POOL, static_cast<intptr_t>(size));
2508 #endif 2512 #endif
2509 } 2513 }
2510 2514
2511 2515
2512 } } // namespace v8::internal 2516 } } // namespace v8::internal
2513 2517
2514 #endif // V8_TARGET_ARCH_A64 2518 #endif // V8_TARGET_ARCH_A64
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698