Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1467313002: Remove SkFontConfigInterface race suppression. (Closed)

Created:
5 years, 1 month ago by bungeman-chromium
Modified:
5 years ago
Reviewers:
mtklein_C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SkFontConfigInterface race suppression. The race was fixed with https://codereview.chromium.org/355573006 , committed as https://skia.googlesource.com/skia/+/e438ddbc7451ec80f953266409fea4695e78c8c2 This is effectively a revert of https://codereview.chromium.org/273523002 . BUG=chromium:369257 Committed: https://crrev.com/a8c01b568251a5dc191e4fb67ab5c1dc6b8af86e Cr-Commit-Position: refs/heads/master@{#361125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M build/sanitizers/tsan_suppressions.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
bungeman-chromium
It doesn't look like we need this suppression anymore, and if we remove this I ...
5 years, 1 month ago (2015-11-23 16:37:05 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467313002/1
5 years, 1 month ago (2015-11-23 16:39:32 UTC) #4
mtklein_C
lgtm thank you
5 years, 1 month ago (2015-11-23 16:48:24 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-23 16:52:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467313002/1
5 years, 1 month ago (2015-11-23 17:03:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 17:10:14 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a8c01b568251a5dc191e4fb67ab5c1dc6b8af86e Cr-Commit-Position: refs/heads/master@{#361125}
5 years, 1 month ago (2015-11-23 17:11:00 UTC) #11
Alexander Potapenko
On 2015/11/23 17:11:00, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
5 years ago (2015-11-24 12:15:25 UTC) #12
Alexander Potapenko
5 years ago (2015-11-24 12:15:59 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1468173005/ by glider@chromium.org.

The reason for reverting is: The data race is still reproducible (see the bug)

BUG=chromium:369257.

Powered by Google App Engine
This is Rietveld 408576698