Issue 1467263002: Fix URL duplication when SetArgsForURL is called mutliple times.

Issue 1467263002: Fix URL duplication when SetArgsForURL is called mutliple times. (Closed)

Created:
5 years, 1 month ago by qsr

Modified:
5 years, 1 month ago

Reviewers:
ppi

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix URL duplication when SetArgsForURL is called mutliple times. R=ppi@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f3b7f561d8c394a6e0c9c8668905ea729138450c

Patch Set 2 : Follow review #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -30 lines)			Patch
M	shell/application_manager/application_manager.cc	View		2 chunks	+13 lines, -10 lines	0 comments	Download
M	shell/application_manager/application_manager_unittest.cc	View	1	4 chunks	+40 lines, -15 lines	0 comments	Download
M	shell/command_line_util.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	shell/command_line_util_unittest.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ppi

lgtm, thanks https://codereview.chromium.org/1467263002/diff/1/shell/application_manager/application_manager_unittest.cc File shell/application_manager/application_manager_unittest.cc (right): https://codereview.chromium.org/1467263002/diff/1/shell/application_manager/application_manager_unittest.cc#newcode553 shell/application_manager/application_manager_unittest.cc:553: // phase. phases

5 years, 1 month ago (2015-11-23 15:02:44 UTC) #2

qsr

https://codereview.chromium.org/1467263002/diff/1/shell/application_manager/application_manager_unittest.cc File shell/application_manager/application_manager_unittest.cc (right): https://codereview.chromium.org/1467263002/diff/1/shell/application_manager/application_manager_unittest.cc#newcode553 shell/application_manager/application_manager_unittest.cc:553: // phase. On 2015/11/23 15:02:44, ppi wrote: > phases ...

5 years, 1 month ago (2015-11-23 17:18:00 UTC) #3

qsr

5 years, 1 month ago (2015-11-23 17:18:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f3b7f561d8c394a6e0c9c8668905ea729138450c (presubmit successful).

Expand Messages | Collapse Messages