shell/command_line_util_unittest.cc - Issue 1467263002: Fix URL duplication when SetArgsForURL is called mutliple times.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: shell/command_line_util_unittest.cc

Issue 1467263002: Fix URL duplication when SetArgsForURL is called mutliple times. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Follow review Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: shell/command_line_util_unittest.cc

diff --git a/shell/command_line_util_unittest.cc b/shell/command_line_util_unittest.cc

index d6761555a1b778ac8654d5505a8c122e3cb6845b..58d76494a01a209edfbb5c97a121d8084956ad67 100644

--- a/shell/command_line_util_unittest.cc

+++ b/shell/command_line_util_unittest.cc

@@ -67,8 +67,6 @@ TEST(CommandLineUtil, GetAppURLAndArgs) {

EXPECT_EQ(GURL(expectation.url), result);

std::vector<std::string> expected_args;

if (expectation.values) {

- if (*expectation.values)

- expected_args.push_back(expectation.url);

for (const char** value = expectation.values; *value; ++value)

expected_args.push_back(*value);

}

« no previous file with comments | « shell/command_line_util.cc ('k') | no next file » | no next file with comments »