Issue 1467183006: Fix two memory leaks from pdfium_unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1467183006: Fix two memory leaks from pdfium_unittests (Closed)

Created:
5 years ago by zhaoqin1

Modified:
5 years ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix two memory leaks from pdfium_unittests - remove redundant alloc in fx_codec_jpx_unittest.cpp - free memory allocated by HexDecode calls in fpdf_parser_decode_unittest.cpp BUG=PDFium:239 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/6c2d736011c09266015d3e2a0b9c08aeba1bbf31

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp	View		4 chunks	+4 lines, -0 lines	0 comments	Download
	M	core/src/fxcodec/codec/fx_codec_jpx_unittest.cpp	View		2 chunks	+0 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

zhaoqin1

5 years ago (2015-11-25 15:45:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6c2d736011c09266015d3e2a0b9c08aeba1bbf31 (presubmit successful).