Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp

Issue 1467183006: Fix two memory leaks from pdfium_unittests (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | core/src/fxcodec/codec/fx_codec_jpx_unittest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 PDFium Authors. All rights reserved. 1 // Copyright 2015 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/include/fpdfapi/fpdf_parser.h" 5 #include "core/include/fpdfapi/fpdf_parser.h"
6 #include "testing/gtest/include/gtest/gtest.h" 6 #include "testing/gtest/include/gtest/gtest.h"
7 7
8 TEST(fpdf_parser_decode, HexDecode) { 8 TEST(fpdf_parser_decode, HexDecode) {
9 { 9 {
10 // Empty src string. 10 // Empty src string.
11 uint8_t* dest = nullptr; 11 uint8_t* dest = nullptr;
12 FX_DWORD dest_size; 12 FX_DWORD dest_size;
13 uint8_t src[] = ""; 13 uint8_t src[] = "";
14 EXPECT_EQ(0, HexDecode(src, 0, dest, dest_size)); 14 EXPECT_EQ(0, HexDecode(src, 0, dest, dest_size));
15 EXPECT_EQ(0, dest_size); 15 EXPECT_EQ(0, dest_size);
16 EXPECT_EQ('\0', dest[0]); 16 EXPECT_EQ('\0', dest[0]);
17 FX_Free(dest);
17 } 18 }
18 19
19 { 20 {
20 // Regular conversion. 21 // Regular conversion.
21 uint8_t* dest = nullptr; 22 uint8_t* dest = nullptr;
22 FX_DWORD dest_size; 23 FX_DWORD dest_size;
23 uint8_t src[] = "12Ac>zzz"; 24 uint8_t src[] = "12Ac>zzz";
24 EXPECT_EQ(5, HexDecode(src, 8, dest, dest_size)); 25 EXPECT_EQ(5, HexDecode(src, 8, dest, dest_size));
25 EXPECT_EQ(2, dest_size); 26 EXPECT_EQ(2, dest_size);
26 EXPECT_EQ(18, dest[0]); 27 EXPECT_EQ(18, dest[0]);
27 EXPECT_EQ(172, dest[1]); 28 EXPECT_EQ(172, dest[1]);
29 FX_Free(dest);
28 } 30 }
29 31
30 { 32 {
31 // Non-multiple length. 33 // Non-multiple length.
32 uint8_t* dest = nullptr; 34 uint8_t* dest = nullptr;
33 FX_DWORD dest_size; 35 FX_DWORD dest_size;
34 uint8_t src[] = "12A>zzz"; 36 uint8_t src[] = "12A>zzz";
35 EXPECT_EQ(4, HexDecode(src, 8, dest, dest_size)); 37 EXPECT_EQ(4, HexDecode(src, 8, dest, dest_size));
36 EXPECT_EQ(2, dest_size); 38 EXPECT_EQ(2, dest_size);
37 EXPECT_EQ(18, dest[0]); 39 EXPECT_EQ(18, dest[0]);
38 EXPECT_EQ(160, dest[1]); 40 EXPECT_EQ(160, dest[1]);
41 FX_Free(dest);
39 } 42 }
40 43
41 { 44 {
42 // Skips unknown characters. 45 // Skips unknown characters.
43 uint8_t* dest = nullptr; 46 uint8_t* dest = nullptr;
44 FX_DWORD dest_size; 47 FX_DWORD dest_size;
45 uint8_t src[] = "12tk \tAc>zzz"; 48 uint8_t src[] = "12tk \tAc>zzz";
46 EXPECT_EQ(10, HexDecode(src, 13, dest, dest_size)); 49 EXPECT_EQ(10, HexDecode(src, 13, dest, dest_size));
47 EXPECT_EQ(2, dest_size); 50 EXPECT_EQ(2, dest_size);
48 EXPECT_EQ(18, dest[0]); 51 EXPECT_EQ(18, dest[0]);
49 EXPECT_EQ(172, dest[1]); 52 EXPECT_EQ(172, dest[1]);
53 FX_Free(dest);
50 } 54 }
51 } 55 }
OLDNEW
« no previous file with comments | « no previous file | core/src/fxcodec/codec/fx_codec_jpx_unittest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698