Fix issue with CHECK in NavigationHandle::CommitNavigation

Fix issue with CHECK in NavigationHandle::CommitNavigation

This CL fixes a crash caused by a CHECK in NavigationHandle::CommitNavigation,
where a wrong RenderFrameHost was set in the NavigationHandle. It also changes
the problematic CHECK in a DCHECK.

BUG=560173
Committed: https://crrev.com/450045496cb629c5598569c43bb0624030ad45e4
Cr-Commit-Position: refs/heads/master@{#361858}

[clamy, 2015-11-23 15:11:43]

Description was changed from

==========
Fix issue with CHECK in NavigationHandle::CommitNavigation

This CL fixes a crash caused by a CHECK in NavigationHandle::CommitNavigation,
where a wrong RenderFrameHost was set in the NavigationHandle. It also changes
the problematic CHECK in a DCHECK.

BUG=560173
==========

to

==========
Fix issue with CHECK in NavigationHandle::CommitNavigation

This CL fixes a crash caused by a CHECK in NavigationHandle::CommitNavigation,
where a wrong RenderFrameHost was set in the NavigationHandle. It also changes
the problematic CHECK in a DCHECK.

BUG=560173
==========

[clamy, 2015-11-23 15:11:43]

clamy@chromium.org changed reviewers:
+ nasko@chromium.org

[clamy, 2015-11-23 15:11:52]

@nasko: PTAL

[nasko, 2015-11-23 22:16:54]

https://codereview.chromium.org/1467143005/diff/1/content/browser/frame_host/...
File content/browser/frame_host/render_frame_host_manager.cc (right):

https://codereview.chromium.org/1467143005/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_frame_host_manager.cc:474:
dest_render_frame_host->navigation_handle()->set_render_frame_host(
Can we move this code within the SetNavigationHandle method? What would be the
case where NavigationHandle should have different RFH than the one owning it?

[clamy, 2015-11-24 10:43:17]

https://codereview.chromium.org/1467143005/diff/1/content/browser/frame_host/...
File content/browser/frame_host/render_frame_host_manager.cc (right):

https://codereview.chromium.org/1467143005/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_frame_host_manager.cc:474:
dest_render_frame_host->navigation_handle()->set_render_frame_host(
On 2015/11/23 22:16:54, nasko wrote:
> Can we move this code within the SetNavigationHandle method? What would be the
> case where NavigationHandle should have different RFH than the one owning it?

Done.

[clamy, 2015-11-25 16:48:38]

@nasko: PTAL - I fixed the issue that was making the bots red.

[nasko, 2015-11-25 21:52:53]

LGTM

[clamy, 2015-11-26 09:37:28]

The CQ bit was checked by clamy@chromium.org

[commit-bot: I haz the power, 2015-11-26 09:37:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467143005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467143005/40001

[commit-bot: I haz the power, 2015-11-26 09:42:27]

Description was changed from

==========
Fix issue with CHECK in NavigationHandle::CommitNavigation

This CL fixes a crash caused by a CHECK in NavigationHandle::CommitNavigation,
where a wrong RenderFrameHost was set in the NavigationHandle. It also changes
the problematic CHECK in a DCHECK.

BUG=560173
==========

to

==========
Fix issue with CHECK in NavigationHandle::CommitNavigation

This CL fixes a crash caused by a CHECK in NavigationHandle::CommitNavigation,
where a wrong RenderFrameHost was set in the NavigationHandle. It also changes
the problematic CHECK in a DCHECK.

BUG=560173
==========

[commit-bot: I haz the power, 2015-11-26 09:42:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-26 09:43:33]

Description was changed from

==========
Fix issue with CHECK in NavigationHandle::CommitNavigation

This CL fixes a crash caused by a CHECK in NavigationHandle::CommitNavigation,
where a wrong RenderFrameHost was set in the NavigationHandle. It also changes
the problematic CHECK in a DCHECK.

BUG=560173
==========

to

==========
Fix issue with CHECK in NavigationHandle::CommitNavigation

This CL fixes a crash caused by a CHECK in NavigationHandle::CommitNavigation,
where a wrong RenderFrameHost was set in the NavigationHandle. It also changes
the problematic CHECK in a DCHECK.

BUG=560173

Committed: https://crrev.com/450045496cb629c5598569c43bb0624030ad45e4
Cr-Commit-Position: refs/heads/master@{#361858}
==========

[commit-bot: I haz the power, 2015-11-26 09:43:34]

Patchset 3 (id:??) landed as
https://crrev.com/450045496cb629c5598569c43bb0624030ad45e4
Cr-Commit-Position: refs/heads/master@{#361858}