content/browser/frame_host/navigator_impl.cc - Issue 1467143005: Fix issue with CHECK in NavigationHandle::CommitNavigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 1467143005: Fix issue with CHECK in NavigationHandle::CommitNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed segfault Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index ce8891c9dc0e4e01226259682576218f197ae006..3e3a4970557964da540c351edd9c03edcde48b1f 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -151,8 +151,6 @@ void NavigatorImpl::DidStartProvisionalLoad(

// DidStartProvisionalLoad should not correspond to a new navigation.

DCHECK_EQ(url, render_frame_host->navigation_handle()->GetURL());

render_frame_host->navigation_handle()->set_is_transferring(false);

- render_frame_host->navigation_handle()->set_render_frame_host(

- render_frame_host);

return;

}

« no previous file with comments | « content/browser/frame_host/navigation_handle_impl.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »