Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Issue 1467133003: Remove unecessary GetGlyphIdMetrics call (Closed)

Created:
5 years, 1 month ago by joshua.litt
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@temptext
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove unecessary GetGlyphIdMetrics call BUG=skia: Committed: https://skia.googlesource.com/skia/+/50aa15b88ab149952dbc69e849139887e8a82410

Patch Set 1 #

Patch Set 2 : nit #

Patch Set 3 : added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M src/gpu/GrBatchFontCache.h View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
M src/gpu/GrBatchFontCache.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/batches/GrAtlasTextBatch.cpp View 1 2 chunks +5 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
joshualitt
With this change we will get glyph id metrics only if we are regenerating glyphs, ...
5 years, 1 month ago (2015-11-23 20:33:14 UTC) #2
bsalomon
lgtm
5 years, 1 month ago (2015-11-23 20:59:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467133003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467133003/40001
5 years, 1 month ago (2015-11-23 21:57:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467133003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467133003/40001
5 years, 1 month ago (2015-11-23 21:58:28 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 22:09:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/50aa15b88ab149952dbc69e849139887e8a82410

Powered by Google App Engine
This is Rietveld 408576698