Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1466333003: Move GrAtlasTextBatch blob regeneration to template (Closed)

Created:
5 years, 1 month ago by joshua.litt
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move GrAtlasTextBatch blob regeneration to template This will remove the runtime branches. I don't think it makes the code any harder to read either BUG=skia: Committed: https://skia.googlesource.com/skia/+/60ce86d4718dab83f33488ec41710ad6763fc7f8

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : tweak #

Patch Set 4 : minor #

Total comments: 4

Patch Set 5 : nits #

Patch Set 6 : nit #

Patch Set 7 : added static assert #

Patch Set 8 : add inline qualifier #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -194 lines) Patch
M src/gpu/batches/GrAtlasTextBatch.h View 1 2 3 4 5 6 7 1 chunk +6 lines, -6 lines 0 comments Download
M src/gpu/batches/GrAtlasTextBatch.cpp View 1 2 3 4 5 6 7 6 chunks +264 lines, -188 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
joshualitt
I think, on the whole, this is easier to read, and it should definitely be ...
5 years, 1 month ago (2015-11-23 17:43:34 UTC) #2
robertphillips
https://codereview.chromium.org/1466333003/diff/60001/src/gpu/batches/GrAtlasTextBatch.cpp File src/gpu/batches/GrAtlasTextBatch.cpp (right): https://codereview.chromium.org/1466333003/diff/60001/src/gpu/batches/GrAtlasTextBatch.cpp#newcode29 src/gpu/batches/GrAtlasTextBatch.cpp:29: if (regenTexCoords) { mv width & height in here ...
5 years, 1 month ago (2015-11-23 18:42:52 UTC) #3
robertphillips
lgtm
5 years, 1 month ago (2015-11-23 20:10:34 UTC) #4
bsalomon
lgtm
5 years, 1 month ago (2015-11-23 20:11:38 UTC) #5
jvanverth1
On 2015/11/23 20:11:38, bsalomon wrote: > lgtm Lgtm too
5 years, 1 month ago (2015-11-23 20:11:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466333003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466333003/120001
5 years, 1 month ago (2015-11-23 20:35:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466333003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466333003/140001
5 years, 1 month ago (2015-11-23 20:53:28 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 21:08:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/60ce86d4718dab83f33488ec41710ad6763fc7f8

Powered by Google App Engine
This is Rietveld 408576698