Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: third_party/WebKit/public/web/WebFrame.h

Issue 1467123003: Create base class for common functionality of Web{Local,Remote}Frame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/web.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/web/WebFrame.h
diff --git a/third_party/WebKit/public/web/WebFrame.h b/third_party/WebKit/public/web/WebFrame.h
index bbecd55bcf9747ca8a88b68b7c9e2378ab36bdb9..c99c667a853d4823ac6e8474213672a8847dc9c1 100644
--- a/third_party/WebKit/public/web/WebFrame.h
+++ b/third_party/WebKit/public/web/WebFrame.h
@@ -63,6 +63,7 @@ class WebData;
class WebDataSource;
class WebDocument;
class WebElement;
+class WebFrameImplBase;
class WebLayer;
class WebLocalFrame;
class WebPerformance;
@@ -679,6 +680,13 @@ public:
// text form. This is used only by layout tests.
virtual WebString layerTreeAsText(bool showDebugInfo = false) const = 0;
+ virtual WebFrameImplBase* toImplBase() = 0;
+ // TODO(dcheng): Fix const-correctness issues and remove this overload.
+ virtual const WebFrameImplBase* toImplBase() const
+ {
+ return const_cast<WebFrame*>(this)->toImplBase();
+ }
+
// Returns the frame inside a given frame or iframe element. Returns 0 if
// the given element is not a frame, iframe or if the frame is empty.
BLINK_EXPORT static WebFrame* fromFrameOwnerElement(const WebElement&);
« no previous file with comments | « third_party/WebKit/Source/web/web.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698