Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Side by Side Diff: third_party/WebKit/public/web/WebFrame.h

Issue 1467123003: Create base class for common functionality of Web{Local,Remote}Frame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/web.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 56
57 namespace blink { 57 namespace blink {
58 58
59 class Frame; 59 class Frame;
60 class OpenedFrameTracker; 60 class OpenedFrameTracker;
61 class Visitor; 61 class Visitor;
62 class WebData; 62 class WebData;
63 class WebDataSource; 63 class WebDataSource;
64 class WebDocument; 64 class WebDocument;
65 class WebElement; 65 class WebElement;
66 class WebFrameImplBase;
66 class WebLayer; 67 class WebLayer;
67 class WebLocalFrame; 68 class WebLocalFrame;
68 class WebPerformance; 69 class WebPerformance;
69 class WebRange; 70 class WebRange;
70 class WebRemoteFrame; 71 class WebRemoteFrame;
71 class WebSecurityOrigin; 72 class WebSecurityOrigin;
72 class WebSharedWorkerRepositoryClient; 73 class WebSharedWorkerRepositoryClient;
73 class WebString; 74 class WebString;
74 class WebURL; 75 class WebURL;
75 class WebURLLoader; 76 class WebURLLoader;
(...skipping 596 matching lines...) Expand 10 before | Expand all | Expand 10 after
672 virtual WebRect selectionBoundsRect() const = 0; 673 virtual WebRect selectionBoundsRect() const = 0;
673 674
674 // Only for testing purpose: 675 // Only for testing purpose:
675 // Returns true if selection.anchorNode has a marker on range from |from| wi th |length|. 676 // Returns true if selection.anchorNode has a marker on range from |from| wi th |length|.
676 virtual bool selectionStartHasSpellingMarkerFor(int from, int length) const = 0; 677 virtual bool selectionStartHasSpellingMarkerFor(int from, int length) const = 0;
677 678
678 // Dumps the layer tree, used by the accelerated compositor, in 679 // Dumps the layer tree, used by the accelerated compositor, in
679 // text form. This is used only by layout tests. 680 // text form. This is used only by layout tests.
680 virtual WebString layerTreeAsText(bool showDebugInfo = false) const = 0; 681 virtual WebString layerTreeAsText(bool showDebugInfo = false) const = 0;
681 682
683 virtual WebFrameImplBase* toImplBase() = 0;
684 // TODO(dcheng): Fix const-correctness issues and remove this overload.
685 virtual const WebFrameImplBase* toImplBase() const
686 {
687 return const_cast<WebFrame*>(this)->toImplBase();
688 }
689
682 // Returns the frame inside a given frame or iframe element. Returns 0 if 690 // Returns the frame inside a given frame or iframe element. Returns 0 if
683 // the given element is not a frame, iframe or if the frame is empty. 691 // the given element is not a frame, iframe or if the frame is empty.
684 BLINK_EXPORT static WebFrame* fromFrameOwnerElement(const WebElement&); 692 BLINK_EXPORT static WebFrame* fromFrameOwnerElement(const WebElement&);
685 693
686 #if BLINK_IMPLEMENTATION 694 #if BLINK_IMPLEMENTATION
687 static WebFrame* fromFrame(Frame*); 695 static WebFrame* fromFrame(Frame*);
688 696
689 bool inShadowTree() const { return m_scope == WebTreeScopeType::Shadow; } 697 bool inShadowTree() const { return m_scope == WebTreeScopeType::Shadow; }
690 698
691 #if ENABLE(OILPAN) 699 #if ENABLE(OILPAN)
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
736 WebPrivateOwnPtr<OpenedFrameTracker> m_openedFrameTracker; 744 WebPrivateOwnPtr<OpenedFrameTracker> m_openedFrameTracker;
737 }; 745 };
738 746
739 #if BLINK_IMPLEMENTATION 747 #if BLINK_IMPLEMENTATION
740 Frame* toCoreFrame(const WebFrame*); 748 Frame* toCoreFrame(const WebFrame*);
741 #endif 749 #endif
742 750
743 } // namespace blink 751 } // namespace blink
744 752
745 #endif 753 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/web.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698