Switch to static_assert in base/.

Switch to static_assert in base/.

BUG=442514
Committed: https://crrev.com/4ec0dffe9e013e64058ff506a76bc822957227aa
Cr-Commit-Position: refs/heads/master@{#361337}

[Avi (use Gerrit), 2015-11-22 00:31:24]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-22 00:32:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467003002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467003002/1

[Avi (use Gerrit), 2015-11-22 00:33:55]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-22 00:34:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467003002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467003002/20001

[Avi (use Gerrit), 2015-11-22 00:48:36]

avi@chromium.org changed reviewers:
+ mark@chromium.org

[Avi (use Gerrit), 2015-11-22 01:07:13]

Description was changed from

==========
Remove COMPILE_ASSERT in base/.

BUG=442514
==========

to

==========
Switch to static_assert in base/.

BUG=442514
==========

[commit-bot: I haz the power, 2015-11-22 04:52:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-22 04:52:10]

Dry run: This issue passed the CQ dry run.

[Mostyn Bramley-Moore, 2015-11-23 06:44:13]

mostynb@opera.com changed reviewers:
+ mostynb@opera.com

[Mostyn Bramley-Moore, 2015-11-23 06:44:14]

It might be slightly better to remove the underscores and camel-casing from the
messages.

https://codereview.chromium.org/1467003002/diff/20001/base/android/jni_androi...
File base/android/jni_android.cc (right):

https://codereview.chromium.org/1467003002/diff/20001/base/android/jni_androi...
base/android/jni_android.cc:147: "AtomicWord_SmallerThan_jMethodID");
s/jMethodID/jclass/ ?

https://codereview.chromium.org/1467003002/diff/20001/base/memory/singleton_u...
File base/memory/singleton_unittest.cc (right):

https://codereview.chromium.org/1467003002/diff/20001/base/memory/singleton_u...
base/memory/singleton_unittest.cc:12:
static_assert(DefaultSingletonTraits<int>::kRegisterAtExit == true, "a");
Maybe change the message to something like "object should be deleted on process
exit" ?

https://codereview.chromium.org/1467003002/diff/20001/base/strings/safe_sprin...
File base/strings/safe_sprintf.cc (right):

https://codereview.chromium.org/1467003002/diff/20001/base/strings/safe_sprin...
base/strings/safe_sprintf.cc:115: // libstdc++4.2 and android uses stlport,
which both don't mark
IIRC we use libc++ on OSX and Android now (not sure about IOS), we can probably
enable this check on those platforms.

[Mark Mentovai, 2015-11-23 14:21:37]

If you produced these mechanically to begin with, it’d be good to say how you
did it in the change description. That’d help others do the same thing elsewhere
in the codebase, and it’s easier to review something that you know was produced
mechanically than it is to have to look for typos.

https://codereview.chromium.org/1467003002/diff/20001/base/android/jni_androi...
File base/android/jni_android.cc (right):

https://codereview.chromium.org/1467003002/diff/20001/base/android/jni_androi...
base/android/jni_android.cc:147: "AtomicWord_SmallerThan_jMethodID");
Can you get rid of the underscores now that we’re doing this transformation too?
This can be a mechanical transformation: it’s probably pretty easy to sed the
diff you’ve already produced to make a new diff that uses spaces instead of
underscores.

https://codereview.chromium.org/1467003002/diff/20001/base/files/file_posix.cc
File base/files/file_posix.cc (right):

https://codereview.chromium.org/1467003002/diff/20001/base/files/file_posix.c...
base/files/file_posix.cc:25: static_assert(File::FROM_BEGIN == SEEK_SET &&
File::FROM_CURRENT == SEEK_CUR &&
clang-formatted is uglier.

[Avi (use Gerrit), 2015-11-23 16:11:02]

So this was mechanical (though the first two steps were manual):

1. s/COMPILE_ASSERT/static_assert/
2. quotify second argument
3. clang format

I can rewrite the second arguments if you wish. As for formatting, yep, that's
what clang format likes.

[Mark Mentovai, 2015-11-23 16:11:47]

Yeah, can you transform those underscores to spaces? Should be easy.

[Avi (use Gerrit), 2015-11-24 00:42:34]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-24 00:47:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467003002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467003002/40001

[commit-bot: I haz the power, 2015-11-24 02:24:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 02:24:58]

Dry run: Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Avi (use Gerrit), 2015-11-24 03:19:24]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-24 03:20:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467003002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467003002/60001

[Avi (use Gerrit), 2015-11-24 03:34:40]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-24 03:38:39]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)

[commit-bot: I haz the power, 2015-11-24 03:39:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467003002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467003002/80001

[Avi (use Gerrit), 2015-11-24 04:49:43]

https://codereview.chromium.org/1467003002/diff/20001/base/memory/singleton_u...
File base/memory/singleton_unittest.cc (right):

https://codereview.chromium.org/1467003002/diff/20001/base/memory/singleton_u...
base/memory/singleton_unittest.cc:12:
static_assert(DefaultSingletonTraits<int>::kRegisterAtExit == true, "a");
On 2015/11/23 06:44:14, Mostyn Bramley-Moore wrote:
> Maybe change the message to something like "object should be deleted on
process
> exit" ?

Done.

https://codereview.chromium.org/1467003002/diff/20001/base/strings/safe_sprin...
File base/strings/safe_sprintf.cc (right):

https://codereview.chromium.org/1467003002/diff/20001/base/strings/safe_sprin...
base/strings/safe_sprintf.cc:115: // libstdc++4.2 and android uses stlport,
which both don't mark
On 2015/11/23 06:44:14, Mostyn Bramley-Moore wrote:
> IIRC we use libc++ on OSX and Android now (not sure about IOS), we can
probably
> enable this check on those platforms.

Done.

[Mark Mentovai, 2015-11-24 05:05:22]

LGTM

[commit-bot: I haz the power, 2015-11-24 06:22:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 06:22:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mostyn Bramley-Moore, 2015-11-24 06:47:30]

Looks like you missed a few underscores in the messages in some files (not that
important though).

[Avi (use Gerrit), 2015-11-24 13:07:54]

On 2015/11/24 06:47:30, Mostyn Bramley-Moore wrote:
> Looks like you missed a few underscores in the messages in some files (not
that
> important though).

Which ones? I left the underscores in where it seemed correct, like scoped_ptr,
etc.

I'm going to land this; if the phrasing of particular messages is important to
you, you can tweak them later.

[Avi (use Gerrit), 2015-11-24 13:08:09]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2015-11-24 13:08:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467003002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467003002/80001

[Mostyn Bramley-Moore, 2015-11-24 13:40:17]

> Which ones? I left the underscores in where it seemed correct, like
scoped_ptr,
> etc.
> 
> I'm going to land this; if the phrasing of particular messages is important to
> you, you can tweak them later.

I will fix these if I'm bored enough later:

In base/logging.h there's "NOT_IMPLEMENTED"
base/win/*.h have "<VariableName>Size"

[commit-bot: I haz the power, 2015-11-24 14:26:32]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-24 14:27:27]

Patchset 5 (id:??) landed as
https://crrev.com/4ec0dffe9e013e64058ff506a76bc822957227aa
Cr-Commit-Position: refs/heads/master@{#361337}