base/logging.h - Issue 1467003002: Switch to static_assert in base/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/logging.h

Issue 1467003002: Switch to static_assert in base/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: / Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/logging.h

diff --git a/base/logging.h b/base/logging.h

index 8c7f20ad193eb1a6f7f398d74788e0fd95c45546..a78b7864c9705647fe56884a8a51c7acdf5b2554 100644

--- a/base/logging.h

+++ b/base/logging.h

@@ -952,9 +952,9 @@ inline std::ostream& operator<<(std::ostream& out, const std::wstring& wstr) {

#define NOTIMPLEMENTED() EAT_STREAM_PARAMETERS

#elif NOTIMPLEMENTED_POLICY == 1

// TODO, figure out how to generate a warning

-#define NOTIMPLEMENTED() COMPILE_ASSERT(false, NOT_IMPLEMENTED)

+#define NOTIMPLEMENTED() static_assert(false, "NOT_IMPLEMENTED")

#elif NOTIMPLEMENTED_POLICY == 2

-#define NOTIMPLEMENTED() COMPILE_ASSERT(false, NOT_IMPLEMENTED)

+#define NOTIMPLEMENTED() static_assert(false, "NOT_IMPLEMENTED")

#elif NOTIMPLEMENTED_POLICY == 3

#define NOTIMPLEMENTED() NOTREACHED()

#elif NOTIMPLEMENTED_POLICY == 4

« no previous file with comments | « base/json/string_escape.cc ('k') | base/mac/foundation_util_unittest.mm » ('j') | no next file with comments »