Settings should not call into inspector

Source/core/page/Page.cpp

Index: Source/core/page/Page.cpp
diff --git a/Source/core/page/Page.cpp b/Source/core/page/Page.cpp
old mode 100644
new mode 100755
index 9a049162fa20f1a1370a3ff27ada57641e8b48cc..4262f9c3015442e9345f5a76388aa7db723f57b3
--- a/Source/core/page/Page.cpp
+++ b/Source/core/page/Page.cpp
@@ -510,6 +510,15 @@ void Page::settingsChanged(SettingsDelegate::ChangeType changeType)
         }
         break;
     case SettingsDelegate::TextAutosizingChange:
+        InspectorInstrumentation::textAutosizingEnabled(mainFrame(), settings().textAutosizingEnabled());

[pfeldman, 2014/01/24 16:25:21]

I don't think we need this complexity in page, consider sending
InspectorInstrumentation::settingsChanged(this, changeType) in the end of this
method instead.

In fact, InspectorInstrumentation:: is only used in core for sniffing and
sending instrumenting signals within core to agents. Changes to settings are
more like messages from embedder (ex-WebKit) that get to the agents via
InspectorController. So I would suggest to

- call inspectorController()->settingsChanged(changeType) here
- in InspectorController, cache the pointer to InspectorPageAgent and delegate
settingsChanged() to it.

[gnana, 2014/01/27 16:31:07]

Done.

+        setNeedsRecalcStyleInAllFrames();
+        break;
+    case SettingsDelegate::ScriptEnableChange:
+        InspectorInstrumentation::scriptsEnabled(mainFrame(), settings().scriptEnabled());
+        break;
+    case SettingsDelegate::DeviceScaleChange:
+        InspectorInstrumentation::fontScaleFactor(mainFrame(), settings().deviceScaleAdjustment());
+
         // FIXME: I wonder if this needs to traverse frames like in WebViewImpl::resize, or whether there is only one document per Settings instance?
         for (Frame* frame = mainFrame(); frame; frame = frame->tree().traverseNext()) {
             TextAutosizer* textAutosizer = frame->document()->textAutosizer();