Settings should not call into inspector

Source/core/page/Page.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All Rights Reserved.
  * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 492 matching lines @@
             (*it)->multisamplingChanged(m_settings->openGLMultisamplingEnabled());
         break;
     }
     case SettingsDelegate::ImageLoadingChange:
         for (Frame* frame = mainFrame(); frame; frame = frame->tree().traverseNext()) {
             frame->document()->fetcher()->setImagesEnabled(settings().imagesEnabled());
             frame->document()->fetcher()->setAutoLoadImages(settings().loadsImagesAutomatically());
         }
         break;
     case SettingsDelegate::TextAutosizingChange:
+        InspectorInstrumentation::textAutosizingEnabled(mainFrame(), settings().textAutosizingEnabled());

[pfeldman, 2014/01/24 16:25:21]

I don't think we need this complexity in page, consider sending
InspectorInstrumentation::settingsChanged(this, changeType) in the end of this
method instead.

In fact, InspectorInstrumentation:: is only used in core for sniffing and
sending instrumenting signals within core to agents. Changes to settings are
more like messages from embedder (ex-WebKit) that get to the agents via
InspectorController. So I would suggest to

- call inspectorController()->settingsChanged(changeType) here
- in InspectorController, cache the pointer to InspectorPageAgent and delegate
settingsChanged() to it.

[gnana, 2014/01/27 16:31:07]

Done.

+        setNeedsRecalcStyleInAllFrames();
+        break;
+    case SettingsDelegate::ScriptEnableChange:
+        InspectorInstrumentation::scriptsEnabled(mainFrame(), settings().scriptEnabled());
+        break;
+    case SettingsDelegate::DeviceScaleChange:
+        InspectorInstrumentation::fontScaleFactor(mainFrame(), settings().deviceScaleAdjustment());
+
         // FIXME: I wonder if this needs to traverse frames like in WebViewImpl::resize, or whether there is only one document per Settings instance?
         for (Frame* frame = mainFrame(); frame; frame = frame->tree().traverseNext()) {
             TextAutosizer* textAutosizer = frame->document()->textAutosizer();
             if (textAutosizer)
                 textAutosizer->recalculateMultipliers();
         }
         setNeedsRecalcStyleInAllFrames();
         break;
     }
 }
@@ skipping 24 matching lines @@
     , backForwardClient(0)
     , spellCheckerClient(0)
 {
 }
 
 Page::PageClients::~PageClients()
 {
 }
 
 } // namespace WebCore