Source/web/WebFrameImpl.cpp - Issue 146683003: Settings should not call into inspector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebFrameImpl.cpp

Issue 146683003: Settings should not call into inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: incorporated review comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebFrameImpl.cpp

diff --git a/Source/web/WebFrameImpl.cpp b/Source/web/WebFrameImpl.cpp

index 29678771db2c0a169a957b96025355c7449d9bfa..89eee4be4e46a16875997270d3db8409662874c4 100644

--- a/Source/web/WebFrameImpl.cpp

+++ b/Source/web/WebFrameImpl.cpp

@@ -826,7 +826,7 @@ void WebFrameImpl::collectGarbage()

{

if (!frame())

return;

- if (!frame()->settings()->isScriptEnabled())

+ if (!frame()->settings()->scriptEnabled())

return;

V8GCController::collectGarbage(v8::Isolate::GetCurrent());

}

« no previous file with comments | « Source/core/testing/InternalSettings.cpp ('k') | Source/web/WebHelperPluginImpl.cpp » ('j') | no next file with comments »