Source/web/WebHelperPluginImpl.cpp - Issue 146683003: Settings should not call into inspector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebHelperPluginImpl.cpp

Issue 146683003: Settings should not call into inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: incorporated review comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebHelperPluginImpl.cpp

diff --git a/Source/web/WebHelperPluginImpl.cpp b/Source/web/WebHelperPluginImpl.cpp

index bf0823689e9e225bfb70c82a9e66e61459dd5e4f..9bbf17968ff4fe052a976d2508af312f476f1194 100644

--- a/Source/web/WebHelperPluginImpl.cpp

+++ b/Source/web/WebHelperPluginImpl.cpp

@@ -208,7 +208,7 @@ bool WebHelperPluginImpl::initializePage(const String& pluginType, const WebDocu

pageClients.chromeClient = m_chromeClient.get();

m_page = adoptPtr(new Page(pageClients));

- ASSERT(!m_page->settings().isScriptEnabled());

+ ASSERT(!m_page->settings().scriptEnabled());

m_page->settings().setPluginsEnabled(true);

m_webView->client()->initializeHelperPluginWebFrame(this);

« no previous file with comments | « Source/web/WebFrameImpl.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »