Source/core/inspector/InspectorPageAgent.cpp - Issue 146683003: Settings should not call into inspector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorPageAgent.cpp

Issue 146683003: Settings should not call into inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: incorporated review comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/inspector/InspectorPageAgent.cpp

diff --git a/Source/core/inspector/InspectorPageAgent.cpp b/Source/core/inspector/InspectorPageAgent.cpp

index c1d6981e267a15ad5347ee3cea975d821f76439b..5f609645ac7b4e10010f68b1b20c1b4b5202e317 100644

--- a/Source/core/inspector/InspectorPageAgent.cpp

+++ b/Source/core/inspector/InspectorPageAgent.cpp

@@ -780,7 +780,7 @@ void InspectorPageAgent::getScriptExecutionStatus(ErrorString*, PageCommandHandl

if (frame) {

disabledByScriptController = !frame->script().canExecuteScripts(NotAboutToExecuteScript);

if (frame->settings())

- disabledInSettings = !frame->settings()->isScriptEnabled();

+ disabledInSettings = !frame->settings()->scriptEnabled();

}

if (!disabledByScriptController) {

« no previous file with comments | « Source/core/inspector/InspectorInstrumentation.idl ('k') | Source/core/page/Page.h » ('j') | no next file with comments »