Source/core/inspector/InspectorInstrumentation.idl - Issue 146683003: Settings should not call into inspector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorInstrumentation.idl

Issue 146683003: Settings should not call into inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: incorporated review comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/inspector/InspectorInstrumentation.idl

diff --git a/Source/core/inspector/InspectorInstrumentation.idl b/Source/core/inspector/InspectorInstrumentation.idl

index 04499981416729f0f13dff06556a15f081692330..ea78ce7d755fe2a6ad480dad470c1afed1022c23 100644

--- a/Source/core/inspector/InspectorInstrumentation.idl

+++ b/Source/core/inspector/InspectorInstrumentation.idl

@@ -217,9 +217,6 @@ interface InspectorInstrumentation {

[Timeline, Inline=FastReturn]

void didEvaluateScript(const InspectorInstrumentationCookie&);

- [Page, Inline=FastReturn]

- void scriptsEnabled(Page*, bool isEnabled);

[PageRuntime, Inline=FastReturn]

void didCreateIsolatedContext([Keep] Frame*, ScriptState*, SecurityOrigin*);