Source/core/fetch/ResourceFetcher.cpp - Issue 146683003: Settings should not call into inspector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/fetch/ResourceFetcher.cpp

Issue 146683003: Settings should not call into inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase & incorporated review comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/fetch/ResourceFetcher.cpp

diff --git a/Source/core/fetch/ResourceFetcher.cpp b/Source/core/fetch/ResourceFetcher.cpp

index 5536ec9738d8fb9d4a0b395b92b6c32ae35dd235..0c6629bc8d787ce19e17ae1d874b4617fafa03eb 100644

--- a/Source/core/fetch/ResourceFetcher.cpp

+++ b/Source/core/fetch/ResourceFetcher.cpp

@@ -506,7 +506,7 @@ bool ResourceFetcher::canRequest(Resource::Type type, const KURL& url, const Res

if (frame()) {

Settings* settings = frame()->settings();

- if (!frame()->loader().client()->allowScriptFromSource(!settings || settings->isScriptEnabled(), url)) {

+ if (!frame()->loader().client()->allowScriptFromSource(!settings || settings->scriptEnabled(), url)) {

frame()->loader().client()->didNotAllowScript();

return false;

}