Source/bindings/v8/ScriptController.cpp - Issue 146683003: Settings should not call into inspector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptController.cpp

Issue 146683003: Settings should not call into inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase & incorporated review comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ScriptController.cpp

diff --git a/Source/bindings/v8/ScriptController.cpp b/Source/bindings/v8/ScriptController.cpp

index e9938b1a18ecb2486bd92a2ddad30ca0f89a29c9..818b9fd1ab575bc83477613ef27bac68c14a0ac3 100644

--- a/Source/bindings/v8/ScriptController.cpp

+++ b/Source/bindings/v8/ScriptController.cpp

@@ -558,7 +558,7 @@ bool ScriptController::canExecuteScripts(ReasonForCallingCanExecuteScripts reaso

}

Settings* settings = m_frame->settings();

- const bool allowed = m_frame->loader().client()->allowScript(settings && settings->isScriptEnabled());

+ const bool allowed = m_frame->loader().client()->allowScript(settings && settings->scriptEnabled());

if (!allowed && reason == AboutToExecuteScript)

m_frame->loader().client()->didNotAllowScript();

return allowed;