Source/core/page/Page.cpp - Issue 146683003: Settings should not call into inspector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/Page.cpp

Issue 146683003: Settings should not call into inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: incorporated review comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/Page.cpp

diff --git a/Source/core/page/Page.cpp b/Source/core/page/Page.cpp

old mode 100644

new mode 100755

index 9a049162fa20f1a1370a3ff27ada57641e8b48cc..7be0cb7ea380c062a76b548bec39cb4f7af7f34f

--- a/Source/core/page/Page.cpp

+++ b/Source/core/page/Page.cpp

@@ -518,7 +518,10 @@ void Page::settingsChanged(SettingsDelegate::ChangeType changeType)

}

setNeedsRecalcStyleInAllFrames();

break;

+ default:

+ break;

}

+ m_inspectorController->settingsChanged();

}

void Page::didCommitLoad(Frame* frame)