Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: Source/core/page/Page.cpp

Issue 146683003: Settings should not call into inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: incorporated review comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All R ights Reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All R ights Reserved.
3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 500 matching lines...) Expand 10 before | Expand all | Expand 10 after
511 break; 511 break;
512 case SettingsDelegate::TextAutosizingChange: 512 case SettingsDelegate::TextAutosizingChange:
513 // FIXME: I wonder if this needs to traverse frames like in WebViewImpl: :resize, or whether there is only one document per Settings instance? 513 // FIXME: I wonder if this needs to traverse frames like in WebViewImpl: :resize, or whether there is only one document per Settings instance?
514 for (Frame* frame = mainFrame(); frame; frame = frame->tree().traverseNe xt()) { 514 for (Frame* frame = mainFrame(); frame; frame = frame->tree().traverseNe xt()) {
515 TextAutosizer* textAutosizer = frame->document()->textAutosizer(); 515 TextAutosizer* textAutosizer = frame->document()->textAutosizer();
516 if (textAutosizer) 516 if (textAutosizer)
517 textAutosizer->recalculateMultipliers(); 517 textAutosizer->recalculateMultipliers();
518 } 518 }
519 setNeedsRecalcStyleInAllFrames(); 519 setNeedsRecalcStyleInAllFrames();
520 break; 520 break;
521 default:
522 break;
521 } 523 }
524 m_inspectorController->settingsChanged();
522 } 525 }
523 526
524 void Page::didCommitLoad(Frame* frame) 527 void Page::didCommitLoad(Frame* frame)
525 { 528 {
526 lifecycleNotifier().notifyDidCommitLoad(frame); 529 lifecycleNotifier().notifyDidCommitLoad(frame);
527 if (m_mainFrame == frame) 530 if (m_mainFrame == frame)
528 useCounter().didCommitLoad(); 531 useCounter().didCommitLoad();
529 } 532 }
530 533
531 PageLifecycleNotifier& Page::lifecycleNotifier() 534 PageLifecycleNotifier& Page::lifecycleNotifier()
(...skipping 15 matching lines...) Expand all
547 , backForwardClient(0) 550 , backForwardClient(0)
548 , spellCheckerClient(0) 551 , spellCheckerClient(0)
549 { 552 {
550 } 553 }
551 554
552 Page::PageClients::~PageClients() 555 Page::PageClients::~PageClients()
553 { 556 {
554 } 557 }
555 558
556 } // namespace WebCore 559 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698