sync: Better iteration in GenericChangeProcessor

sync/syncable/entry.h

Index: sync/syncable/entry.h
diff --git a/sync/syncable/entry.h b/sync/syncable/entry.h
index f9d3f90cc97bef33414c8d690f89b0bec246ad53..9bb9164d6c775d3898a0549e3cf12a6eec9eba73 100644
--- a/sync/syncable/entry.h
+++ b/sync/syncable/entry.h
@@ -109,6 +109,14 @@ class SYNC_EXPORT Entry {
   Id GetSuccessorId() const;
   Id GetFirstChildId() const;
 
+  // Returns a vector of this node's handles.
+  // The list is a snapshot of the state at the time this function was called;

[Nicolas Zea, 2013/05/22 22:34:02]

nit: I don't think it's necessary to call out that |result| won't be updated or
that it's a snapshot at the time it was called. That's the case for all Get*
methods, and would be weird otherwise.

[rlarocque, 2013/05/23 00:39:39]

Done.

+  // it will not be updated as the directory is modified.  Clears |result| if
+  // there are no children.  If this node is of a type that supports
+  // user-defined ordering, then the resulting vector will be in the proper
+  // order.
+  void GetChildHandles(std::vector<int64>* result) const;
+
   inline bool ExistsOnClientBecauseNameIsNonEmpty() const {
     DCHECK(kernel_);
     return !kernel_->ref(NON_UNIQUE_NAME).empty();
@@ -140,6 +148,10 @@ class SYNC_EXPORT Entry {
       : basetrans_(trans),
         kernel_(NULL) { }
 
+  Entry(BaseTransaction* trans, EntryKernel *kernel)

[Nicolas Zea, 2013/05/22 22:34:02]

what is this used by?

[rlarocque, 2013/05/23 00:39:39]

Nothing.  I thought I had removed that code.  Apparently I missed one.  

+      : basetrans_(trans),
+        kernel_(kernel) { }
+
  protected:
   BaseTransaction* const basetrans_;