sync: Better iteration in GenericChangeProcessor

sync/syncable/entry.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SYNC_SYNCABLE_ENTRY_H_
 #define SYNC_SYNCABLE_ENTRY_H_
 
 #include "sync/base/sync_export.h"
 #include "sync/syncable/entry_kernel.h"
 
@@ skipping 91 matching lines @@
     return kernel_->ref(field);
   }
 
   ModelType GetServerModelType() const;
   ModelType GetModelType() const;
 
   Id GetPredecessorId() const;
   Id GetSuccessorId() const;
   Id GetFirstChildId() const;
 
+  // Returns a vector of this node's handles.
+  // The list is a snapshot of the state at the time this function was called;

[Nicolas Zea, 2013/05/22 22:34:02]

nit: I don't think it's necessary to call out that |result| won't be updated or
that it's a snapshot at the time it was called. That's the case for all Get*
methods, and would be weird otherwise.

[rlarocque, 2013/05/23 00:39:39]

Done.

+  // it will not be updated as the directory is modified.  Clears |result| if
+  // there are no children.  If this node is of a type that supports
+  // user-defined ordering, then the resulting vector will be in the proper
+  // order.
+  void GetChildHandles(std::vector<int64>* result) const;
+
   inline bool ExistsOnClientBecauseNameIsNonEmpty() const {
     DCHECK(kernel_);
     return !kernel_->ref(NON_UNIQUE_NAME).empty();
   }
 
   inline bool IsRoot() const {
     DCHECK(kernel_);
     return kernel_->ref(ID).IsRoot();
   }
 
@@ skipping 11 matching lines @@
   // Transfers ownership of the DictionaryValue to the caller.
   base::DictionaryValue* ToValue(Cryptographer* cryptographer) const;
 
  protected:  // Don't allow creation on heap, except by sync API wrappers.
   void* operator new(size_t size) { return (::operator new)(size); }
 
   inline explicit Entry(BaseTransaction* trans)
       : basetrans_(trans),
         kernel_(NULL) { }
 
+  Entry(BaseTransaction* trans, EntryKernel *kernel)

[Nicolas Zea, 2013/05/22 22:34:02]

what is this used by?

[rlarocque, 2013/05/23 00:39:39]

Nothing.  I thought I had removed that code.  Apparently I missed one.  

+      : basetrans_(trans),
+        kernel_(kernel) { }
+
  protected:
   BaseTransaction* const basetrans_;
 
   EntryKernel* kernel_;
 
  private:
   friend class Directory;
   friend class syncer::ReadNode;
   friend std::ostream& operator << (std::ostream& s, const Entry& e);
 
   DISALLOW_COPY_AND_ASSIGN(Entry);
 };
 
 std::ostream& operator<<(std::ostream& os, const Entry& entry);
 
 }  // namespace syncable
 }  // namespace syncer
 
 #endif  // SYNC_SYNCABLE_ENTRY_H_